Re: [PATCH v5 2/2] clocksource: driver for Conexant Digicolor SoC timer

Daniel Lezcano
2015-01-26T13:58:23Z

On 01/26/2015 02:47 PM, Baruch Siach wrote:
> Hi Daniel,
>
> On Mon, Jan 26, 2015 at 02:44:15PM +0100, Daniel Lezcano wrote:
>>> diff --git a/drivers/clocksource/Makefile b/drivers/clocksource/Makefile
>>> index 94d90b24b56b..a993c108be67 100644
>>> --- a/drivers/clocksource/Makefile
>>> +++ b/drivers/clocksource/Makefile
>>> @@ -10,6 +10,7 @@ obj-$(CONFIG_SH_TIMER_TMU) += sh_tmu.o
>>> obj-$(CONFIG_EM_TIMER_STI) += em_sti.o
>>> obj-$(CONFIG_CLKBLD_I8253) += i8253.o
>>> obj-$(CONFIG_CLKSRC_MMIO) += mmio.o
>>> +obj-$(CONFIG_ARCH_DIGICOLOR) += timer-digicolor.o
>>
>> Ah, one minor change I forgot to mention in the last review (sorry about
>> that).
>>
>> Don't depend on the ARCH, add and select a TIMER_DIGICOLOR (or whatever the
>> name you prefer) in the mach-digicolor/Kconfig and use it here.
>
> OK. I'll make the change. I'm just curious: what is the advantage of having a
> separate config symbol for the timer?

It is because some timers could be used in different platforms, so the
policy of the house is to let the platform Kconfig to select the timer.

Also, that let one platform to not select the timer if it is not needed.
For example one SoC uses the architected timers and there is not power
management on the board, hence no cpu is powered down and no backup
timer is needed.

Even if the timer is expected to be used on only one platform, we try to
keep the rule consistent across the different drivers (even if I admit
some cleanups should be done in the Kconfig file).

--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |