From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755662AbbAZPpw (ORCPT ); Mon, 26 Jan 2015 10:45:52 -0500 Received: from mail-pd0-f179.google.com ([209.85.192.179]:61682 "EHLO mail-pd0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753127AbbAZPp3 (ORCPT ); Mon, 26 Jan 2015 10:45:29 -0500 Date: Tue, 27 Jan 2015 00:45:19 +0900 From: Minchan Kim To: Ganesh Mahendran Cc: ngupta@vflare.org, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] zram: free meta table in zram_meta_free Message-ID: <20150126154506.GA528@blaptop> References: <1422107153-9701-1-git-send-email-opensource.ganesh@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1422107153-9701-1-git-send-email-opensource.ganesh@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On Sat, Jan 24, 2015 at 09:45:53PM +0800, Ganesh Mahendran wrote: > zram_meta_alloc() and zram_meta_free() are a pair. > In zram_meta_alloc(), meta table is allocated. So it it better to free > it in zram_meta_free(). > > Signed-off-by: Ganesh Mahendran > Cc: Nitin Gupta > Cc: Minchan Kim Looks good to me but it seems the patch is based on my recent work "zram: free meta out of init_lock". Please resend it on recent mmotm because I will respin my patch and your patch is orthogonal with mine. Thanks.