From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756234AbbAZTsw (ORCPT ); Mon, 26 Jan 2015 14:48:52 -0500 Received: from mx2.parallels.com ([199.115.105.18]:38345 "EHLO mx2.parallels.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755359AbbAZTst (ORCPT ); Mon, 26 Jan 2015 14:48:49 -0500 Date: Mon, 26 Jan 2015 22:48:38 +0300 From: Vladimir Davydov To: Christoph Lameter CC: Andrew Morton , Pekka Enberg , David Rientjes , Joonsoo Kim , Johannes Weiner , Michal Hocko , , Subject: Re: [PATCH -mm 2/3] slab: zap kmem_cache_shrink return value Message-ID: <20150126194838.GB2660@esperanza> References: <20150126170418.GC28978@esperanza> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 26, 2015 at 12:26:57PM -0600, Christoph Lameter wrote: > On Mon, 26 Jan 2015, Vladimir Davydov wrote: > > > __cache_shrink() is used not only in __kmem_cache_shrink(), but also in > > SLAB's __kmem_cache_shutdown(), where we do need its return value to > > check if the cache is empty. > > It could be useful to know if a slab is empty. So maybe leave > kmem_cache_shrink the way it is and instead fix up slub to return the > proper value? Hmm, why? The return value has existed since this function was introduced, but nobody seems to have ever used it outside the slab core. Besides, this check is racy, so IMO we shouldn't encourage users of the API to rely on it. That said, I believe we should drop the return value for now. If anybody ever needs it, we can reintroduce it. Thanks, Vladimir