From: Dan Carpenter <dan.carpenter@oracle.com>
To: Heba Aamer <heba93aamer@gmail.com>
Cc: devel@driverdev.osuosl.org, florian.c.schilhabel@googlemail.com,
thomas@grouk.net, tapaswenipathak@gmail.com,
gregkh@linuxfoundation.org,
rickard_strandqvist@spectrumdigital.se,
linux-kernel@vger.kernel.org, sudipm.mukherjee@gmail.com,
Larry.Finger@lwfinger.net
Subject: Re: [PATCH v2] staging: rtl8712: fix Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then dev_info(dev, ... then pr_info(... to printk(KERN_INFO ...
Date: Tue, 27 Jan 2015 13:17:19 +0300 [thread overview]
Message-ID: <20150127101719.GS6456@mwanda> (raw)
In-Reply-To: <20150126125229.GA11609@mohammed-Inspiron-3537>
The subject line is too long.
> - printk(KERN_INFO "r8712u: Staging version\n");
> + pr_info("r8712u: Staging version\n");
This is a dumb thing to print. Just delete this line.
regards,
dan carpenter
prev parent reply other threads:[~2015-01-27 10:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-26 12:52 [PATCH v2] staging: rtl8712: fix Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then dev_info(dev, ... then pr_info(... to printk(KERN_INFO Heba Aamer
2015-01-27 10:17 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150127101719.GS6456@mwanda \
--to=dan.carpenter@oracle.com \
--cc=Larry.Finger@lwfinger.net \
--cc=devel@driverdev.osuosl.org \
--cc=florian.c.schilhabel@googlemail.com \
--cc=gregkh@linuxfoundation.org \
--cc=heba93aamer@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rickard_strandqvist@spectrumdigital.se \
--cc=sudipm.mukherjee@gmail.com \
--cc=tapaswenipathak@gmail.com \
--cc=thomas@grouk.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox