From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Mark Rutland <mark.rutland@arm.com>
Cc: Jiri Kosina <jkosina@suse.cz>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <Pawel.Moll@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Jarkko Nikula <jarkko.nikula@linux.intel.com>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] HID: i2c-hid: Add support for GPIO interrupts
Date: Tue, 27 Jan 2015 16:41:27 +0200 [thread overview]
Message-ID: <20150127144127.GT1451@lahna.fi.intel.com> (raw)
In-Reply-To: <20150127143334.GF17721@leverpostej>
On Tue, Jan 27, 2015 at 02:33:34PM +0000, Mark Rutland wrote:
> Ok, that allays my fear w.r.t. ordering of the resources.
>
> As I see it, the fact that we convert GpioInt entries to GPIOs rather
> than irqs when parsing _CRS is the issue here, and to me it makes no
> sense that we do so. Were we to treat them as interrupts, the binding is
> fine as-is, and we'd do the same thing in DT and ACPI.
>
> The reason GpioInt is separate from GpioIo is that a GpioInt _is_ an
> interrupt (which happens to be backed by a GPIO), and is not something
> that necessarily makes sense as a GPIO.
I would rather say that GpioInt *is* a GPIO. That can then used as an
interrupt but it should not prevent you from using it as GPIO instead.
For example if you just want to poll that something is 0 or 1. That
should be possible as well and nothing say that you cannot do that for
GpioInt().
> So why do we currently ignore the GpioInt/GpioIo distinction and treat
> GpioInts as GPIOs rather than interrupts?
See above.
next prev parent reply other threads:[~2015-01-27 14:41 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-26 14:29 [PATCH 1/2] HID: i2c-hid: The interrupt should be level sensitive Mika Westerberg
2015-01-26 14:29 ` [PATCH 2/2] HID: i2c-hid: Add support for GPIO interrupts Mika Westerberg
2015-01-26 14:37 ` Mark Rutland
2015-01-26 14:47 ` Mika Westerberg
2015-01-26 14:50 ` Mark Rutland
2015-01-26 15:16 ` Mika Westerberg
2015-01-26 16:01 ` Mark Rutland
2015-01-26 16:13 ` Mika Westerberg
2015-01-26 16:39 ` Mark Rutland
2015-01-27 10:16 ` Mika Westerberg
2015-01-27 10:39 ` Mark Rutland
2015-01-27 10:59 ` Mika Westerberg
2015-01-27 11:14 ` Mark Rutland
2015-01-27 11:30 ` Mika Westerberg
2015-01-27 14:33 ` Mark Rutland
2015-01-27 14:41 ` Mika Westerberg [this message]
2015-01-27 15:06 ` Mark Rutland
2015-01-27 15:21 ` Mika Westerberg
2015-01-27 15:57 ` Mark Rutland
2015-01-27 17:10 ` Mika Westerberg
2015-01-29 20:09 ` [PATCH 1/2] HID: i2c-hid: The interrupt should be level sensitive Benjamin Tissoires
2015-02-17 12:24 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150127144127.GT1451@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=Pawel.Moll@arm.com \
--cc=benjamin.tissoires@redhat.com \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jarkko.nikula@linux.intel.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox