From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932337AbbA0P0S (ORCPT ); Tue, 27 Jan 2015 10:26:18 -0500 Received: from mail-wi0-f177.google.com ([209.85.212.177]:35854 "EHLO mail-wi0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754637AbbA0P0P (ORCPT ); Tue, 27 Jan 2015 10:26:15 -0500 From: Pali =?utf-8?q?Roh=C3=A1r?= To: Nicolas Pitre Subject: Re: N900 v3.19-rc5 arm atags_to_fdt.c is broken Date: Tue, 27 Jan 2015 16:26:12 +0100 User-Agent: KMail/1.13.7 (Linux/3.13.0-44-generic; KDE/4.14.2; x86_64; ; ) Cc: Pavel Machek , Tony Lindgren , "linux-omap" , Linux Kernel Mailing List , Aaro Koskinen , Sebastian Reichel , Ivaylo Dimitrov , Russell King , linux-arm-kernel@lists.infradead.org, Laura Abbott References: <201501232239.55801@pali> <20150127133739.GB25306@amd> In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart7652450.5ovlhcguvg"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201501271626.12365@pali> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --nextPart7652450.5ovlhcguvg Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Tuesday 27 January 2015 16:16:24 Nicolas Pitre wrote: > On Tue, 27 Jan 2015, Pavel Machek wrote: > > > > > I would say, problem is because omap3-n900 binary DT > > > > > is too large > > >=20 > > > I agree. > > >=20 > > > > OK if that's the case, then your patch makes sense to > > > > me. It also seems we can have the temporary stack be > > > > larger than the initial stack just for atags_to_fdt. > > >=20 > > > The stack size isn't the issue, but rather its location.=20 > > > We need to position it away from the DT data. The DT > > > size is known and we could use that, plus some room for > > > the insertion of new data coming from the ATAG > > > conversion. > >=20 > > > Something like the following would be a more robust=20 solution: > > Tested-by: Pavel Machek > >=20 > > (Note, that in 3.19 dts for n900 got too big, so we are > > actually triggering old bugs. That means that this is a > > regression fix, and should go in ASAP). >=20 > It is queued here: > http://www.arm.linux.org.uk/developer/patches/viewpatch.php?id > =3D8294/1 >=20 >=20 > Nicolas I tested your patch and fdt_open_into() does not return error=20 =46DT_ERR_NOSPACE anymore. It is working. So you can add my Tested-by: Pali Roh=C3=A1r =2D-=20 Pali Roh=C3=A1r pali.rohar@gmail.com --nextPart7652450.5ovlhcguvg Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iEYEABECAAYFAlTHrhQACgkQi/DJPQPkQ1ITGgCgjuACJmD7pKBWO+KaJiKr3h7F MGMAn3+XQ24od9puhEWNTXwXgguhzZzw =vNKF -----END PGP SIGNATURE----- --nextPart7652450.5ovlhcguvg--