From: Guenter Roeck <linux@roeck-us.net>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Zubair Lutfullah Kakakhel <Zubair.Kakakhel@imgtec.com>,
wim@iguana.be, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org,
paul@crapouillou.net
Subject: Re: [PATCH 1/2] dt: watchdog: Add DT binding documentation for jz47xx watchdog timer
Date: Tue, 27 Jan 2015 12:52:29 -0800 [thread overview]
Message-ID: <20150127205229.GA6983@roeck-us.net> (raw)
In-Reply-To: <11680810.808F8uDyN0@wuerfel>
On Tue, Jan 27, 2015 at 09:16:45PM +0100, Arnd Bergmann wrote:
> On Tuesday 27 January 2015 15:11:29 Zubair Lutfullah Kakakhel wrote:
> > +clocks: phandle to rtcclk
> > +clock-names: must be "rtc"
> > +
> > +Example:
> > +
> > +watchdog: jz47xx-watchdog@0x10002000 {
> > + compatible = "ingenic,jz4780-watchdog";
> > + reg = <0x10002000 0x100>;
> > +
> > + clocks = <&rtclk>;
> > + clock-names = "rtc";
> > +};
>
> Why is the name "rtc"? are you sure you are not confusing the output
> name of the clock controller with the input of the watchdog device?
>
Driver does this (today):
drvdata->rtc_clk = clk_get(&pdev->dev, "rtc");
Isn't that the name to use ? Just wondering.
Thanks,
Guenter
next prev parent reply other threads:[~2015-01-28 6:26 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-27 15:11 [PATCH 0/2] watchdog: jz4740: Add DT support Zubair Lutfullah Kakakhel
2015-01-27 15:11 ` [PATCH 1/2] dt: watchdog: Add DT binding documentation for jz47xx watchdog timer Zubair Lutfullah Kakakhel
2015-01-27 16:30 ` Guenter Roeck
2015-01-27 20:16 ` Arnd Bergmann
2015-01-27 20:52 ` Guenter Roeck [this message]
2015-01-27 21:29 ` Arnd Bergmann
2015-01-27 22:19 ` Guenter Roeck
2015-01-27 22:36 ` Arnd Bergmann
2015-01-27 22:42 ` Arnd Bergmann
2015-01-28 10:27 ` Zubair Lutfullah Kakakhel
2015-01-28 11:23 ` Arnd Bergmann
2015-01-27 15:11 ` [PATCH 2/2] watchdog: jz4740: Add DT support Zubair Lutfullah Kakakhel
2015-01-27 16:31 ` Guenter Roeck
2015-01-27 20:15 ` Arnd Bergmann
2015-01-27 20:54 ` Guenter Roeck
2015-01-27 21:23 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150127205229.GA6983@roeck-us.net \
--to=linux@roeck-us.net \
--cc=Zubair.Kakakhel@imgtec.com \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=paul@crapouillou.net \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox