From: Baruch Siach <baruch@tkos.co.il>
To: Lyra Zhang <zhang.lyra@gmail.com>
Cc: "Chunyan Zhang" <chunyan.zhang@spreadtrum.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"Mark Rutland" <mark.rutland@arm.com>,
"gnomes@lxorguk.ukuu.org.uk" <gnomes@lxorguk.ukuu.org.uk>,
"Heiko Stübner" <heiko@sntech.de>,
"andrew@lunn.ch" <andrew@lunn.ch>,
"jslaby@suse.cz" <jslaby@suse.cz>,
"lanqing.liu@spreadtrum.com" <lanqing.liu@spreadtrum.com>,
"Arnd Bergmann" <arnd@arndb.de>,
"zhizhou.zhang" <zhizhou.zhang@spreadtrum.com>,
"geng.ren@spreadtrum.com" <geng.ren@spreadtrum.com>,
"antonynpavlov@gmail.com" <antonynpavlov@gmail.com>,
"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
"Grant Likely" <grant.likely@linaro.org>,
"Orson Zhai" <orsonzhai@gmail.com>,
"florian.vaussard@epfl.ch" <florian.vaussard@epfl.ch>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"jason@lakedaemon.net" <jason@lakedaemon.net>,
"Pawel Moll" <pawel.moll@arm.com>,
"ijc+devicetree@hellion.org.uk" <ijc+devicetree@hellion.org.uk>,
"Hayato Suzuki" <hytszk@gmail.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"Wei Qiao (乔伟)" <wei.qiao@spreadtrum.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"Peter Hurley" <peter@hurleysoftware.com>,
"linux-api@vger.kernel.org" <linux-api@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Kumar Gala" <galak@codeaurora.org>,
"Shawn Guo" <shawn.guo@linaro.org>
Subject: Re: [PATCH v9 2/2] tty/serial: Add Spreadtrum sc9836-uart driver support
Date: Wed, 28 Jan 2015 11:54:01 +0200 [thread overview]
Message-ID: <20150128095401.GC14175@tarshish> (raw)
In-Reply-To: <CAAfSe-v4FGpHL3N3utiDwcoc7qus1XZZszuXBqB6LeE1frAfeA@mail.gmail.com>
Hi Lyra Zhang,
On Wed, Jan 28, 2015 at 04:46:33PM +0800, Lyra Zhang wrote:
> On Wed, Jan 28, 2015 at 2:12 PM, Baruch Siach <baruch@tkos.co.il> wrote:
> > On Wed, Jan 28, 2015 at 10:47:41AM +0800, Chunyan Zhang wrote:
> >> + if (uart_handle_sysrq_char(port, ch))
> >> + continue;
> >
> > My comment[1] on a previous version of this patch still stands.
> > uart_handle_sysrq_char is a NOP when SUPPORT_SYSRQ is not defined.
>
> yes, there are two definitions in serial_core.h, and it returns 0 when
> SUPPORT_SYSRQ is not defined.
> so, I think my code behavior does not hurt, right?
Right. I just wanted to point out that you can easily define SUPPORT_SYSRQ as
appropriate like many other serial drivers do to get sysrq support.
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
next prev parent reply other threads:[~2015-01-28 20:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <sc9836-serial-v9>
2015-01-28 2:47 ` [PATCH v9 0/2] Add Spreadtrum SoC bindings and serial driver support Chunyan Zhang
2015-01-28 2:47 ` [PATCH v9 1/2] Documentation: DT: Add bindings for Spreadtrum SoC Platform Chunyan Zhang
2015-01-28 2:47 ` [PATCH v9 2/2] tty/serial: Add Spreadtrum sc9836-uart driver support Chunyan Zhang
2015-01-28 3:59 ` Peter Hurley
2015-01-28 6:12 ` Baruch Siach
2015-01-28 8:46 ` Lyra Zhang
2015-01-28 9:54 ` Baruch Siach [this message]
2015-01-28 10:46 ` Lyra Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150128095401.GC14175@tarshish \
--to=baruch@tkos.co.il \
--cc=andrew@lunn.ch \
--cc=antonynpavlov@gmail.com \
--cc=arnd@arndb.de \
--cc=chunyan.zhang@spreadtrum.com \
--cc=devicetree@vger.kernel.org \
--cc=florian.vaussard@epfl.ch \
--cc=galak@codeaurora.org \
--cc=geng.ren@spreadtrum.com \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=grant.likely@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=heiko@sntech.de \
--cc=hytszk@gmail.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jason@lakedaemon.net \
--cc=jslaby@suse.cz \
--cc=lanqing.liu@spreadtrum.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=orsonzhai@gmail.com \
--cc=pawel.moll@arm.com \
--cc=peter@hurleysoftware.com \
--cc=robh+dt@kernel.org \
--cc=shawn.guo@linaro.org \
--cc=wei.qiao@spreadtrum.com \
--cc=zhang.lyra@gmail.com \
--cc=zhizhou.zhang@spreadtrum.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox