From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Simon Guo <wei.guo.simon@gmail.com>
Cc: Ian Abbott <abbotti@mev.co.uk>,
H Hartley Sweeten <hsweeten@visionengravers.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3.19.0-rc5 01/03] STAGING: Fix pcl818.c coding style issue: code indent should use tabs where possible
Date: Wed, 28 Jan 2015 11:21:42 -0800 [thread overview]
Message-ID: <20150128192142.GA17038@kroah.com> (raw)
In-Reply-To: <20150126131627.GA9183@thunderCat>
On Mon, Jan 26, 2015 at 09:16:28PM +0800, Simon Guo wrote:
> Correct one coding style problem(detected by checkpatch.pl) in pcl818.c.
> - code indent should use tabs where possible
> It is fixed by reformatting the comment block to usual comment style.
>
> Signed-off-by: Simon Guo <wei.guo.simon@gmail.com>
> ---
> drivers/staging/comedi/drivers/pcl818.c | 195 ++++++++++++++++----------------
> 1 file changed, 97 insertions(+), 98 deletions(-)
When you resend patches, please let me know what version of the patch
series this is, with a "v2" or something in the subject area.
Right now I see a bunch of patches from you, but no clue as to which is
the 'latest' and what changed in what version.
So I'm going to drop them all, please resend.
Also, you don't need the kernel version in the [PATCH] area, as we are
always assuming you are making the patch against the latest kernel
version, hopefully my staging-testing branch, otherwise we couldn't
apply it no matter what.
thanks,
greg k-h
next prev parent reply other threads:[~2015-01-28 20:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-26 13:16 [PATCH 3.19.0-rc5 01/03] STAGING: Fix pcl818.c coding style issue: code indent should use tabs where possible Simon Guo
2015-01-26 14:46 ` Ian Abbott
2015-01-28 19:21 ` Greg Kroah-Hartman [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-01-25 9:28 Simon Guo
2015-01-26 11:31 ` Ian Abbott
2015-01-26 12:52 ` Simon Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150128192142.GA17038@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=abbotti@mev.co.uk \
--cc=devel@driverdev.osuosl.org \
--cc=hsweeten@visionengravers.com \
--cc=linux-kernel@vger.kernel.org \
--cc=wei.guo.simon@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).