Re: [Patch v2 09/22] ACPI: Fix a bug in parsing ACPI Memroy24 resource

Bjorn Helgaas
2015-01-29T01:59:32Z

"Memory24", not "Memroy24", in subject.

On Wed, Jan 28, 2015 at 06:57:27PM +0800, Jiang Liu wrote:
> According to ACPI spec 5, section 6.4.3.1 "24-Bit Memory Range Descriptor",
> minimum, maximum and address_length field in struct acpi_resource_memory24
> is in granularity of 256-bytes. So shift 8-bit left to get correct address.
>
> Signed-off-by: Jiang Liu <jiang.liu@linux.intel.com>
> ---
> drivers/acpi/resource.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/acpi/resource.c b/drivers/acpi/resource.c
> index 7ce00a63f695..5544c6d26f32 100644
> --- a/drivers/acpi/resource.c
> +++ b/drivers/acpi/resource.c
> @@ -90,8 +90,8 @@ bool acpi_dev_resource_memory(struct acpi_resource *ares, struct resource *res)
> switch (ares->type) {
> case ACPI_RESOURCE_TYPE_MEMORY24:
> memory24 = &ares->data.memory24;
> - acpi_dev_get_memresource(res, memory24->minimum,
> - memory24->address_length,
> + acpi_dev_get_memresource(res, memory24->minimum << 8,
> + memory24->address_length << 8,
> memory24->write_protect);
> break;
> case ACPI_RESOURCE_TYPE_MEMORY32:
> --
> 1.7.10.4
>