Re: [PATCH 02/24] Documentation: DT bindings: add more chip compatible strings for Tegra PCIe

Paul Walmsley
2015-01-29T15:45:40Z

Hi Rob

On Thu, 29 Jan 2015, Rob Herring wrote:

> On Wed, Jan 28, 2015 at 5:49 PM, Paul Walmsley <paul@pwsan.com> wrote:
> >
> > Add compatible strings for the PCIe IP blocks present on several Tegra
> > chips. The primary objective here is to avoid checkpatch warnings,
> > per:
> >
> > http://marc.info/?l=linux-tegra&m=142201349727836&w=2
> >
> > Signed-off-by: Paul Walmsley <paul@pwsan.com>
> > Cc: Thierry Reding <thierry.reding@gmail.com>
> > Cc: Rob Herring <robh+dt@kernel.org>
> > Cc: Pawel Moll <pawel.moll@arm.com>
> > Cc: Mark Rutland <mark.rutland@arm.com>
> > Cc: Ian Campbell <ijc+devicetree@hellion.org.uk>
> > Cc: Kumar Gala <galak@codeaurora.org>
> > Cc: Stephen Warren <swarren@wwwdotorg.org>
> > Cc: Alexandre Courbot <gnurou@gmail.com>
> > Cc: linux-tegra@vger.kernel.org
> > Cc: linux-pci@vger.kernel.org
> > Cc: devicetree@vger.kernel.org
> > Cc: linux-kernel@vger.kernel.org
> > ---
> > .../bindings/pci/nvidia,tegra20-pcie.txt | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/pci/nvidia,tegra20-pcie.txt b/Documentation/devicetree/bindings/pci/nvidia,tegra20-pcie.txt
> > index d763e047c6ae..e772884f1c33 100644
> > --- a/Documentation/devicetree/bindings/pci/nvidia,tegra20-pcie.txt
> > +++ b/Documentation/devicetree/bindings/pci/nvidia,tegra20-pcie.txt
> > @@ -5,6 +5,8 @@ Required properties:
> > - "nvidia,tegra20-pcie"
> > - "nvidia,tegra30-pcie"
> > - "nvidia,tegra124-pcie"
> > + - "nvidia,tegra132-pcie" (not yet matched in the driver)
> > + - "nvidia,tegra210-pcie" (not yet matched in the driver)
>
> Whether the driver matches or not is irrelevant to the binding and may
> change over time. Does this mean the driver matches on something else
> or Tegra132 is not yet supported in the driver?

It means that the driver currently matches on one of the first three
strings that don't carry that annotation.

> If the former, what is important is what are the valid combinations of
> compatible properties and that is not captured here. In other words,
> what is the fallback compatible string for each chip?

The intention was to try to be helpful: to document that anyone adding a
"nvidia,tegra132-pcie" compatible string would also need to add one of the
other strings as a fallback. Would you like that to be documented in a
different way, or removed?

- Paul