From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Takashi Iwai <tiwai@suse.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/base/node: Avoid manual device_create_file() calls
Date: Thu, 29 Jan 2015 06:35:48 -0800 [thread overview]
Message-ID: <20150129143548.GA9723@kroah.com> (raw)
In-Reply-To: <1422530962-2460-1-git-send-email-tiwai@suse.de>
On Thu, Jan 29, 2015 at 12:29:22PM +0100, Takashi Iwai wrote:
> Instead of manual calls of multiple device_create_file() and
> device_remove_file(), use the static attribute groups assigned to the
> new device. This also fixes the possible races, too.
>
> Signed-off-by: Takashi Iwai <tiwai@suse.de>
> ---
> drivers/base/node.c | 34 ++++++++++++++++++++--------------
> 1 file changed, 20 insertions(+), 14 deletions(-)
Looks good, I'll queue this up soon, thanks for doing it.
greg k-h
prev parent reply other threads:[~2015-01-29 14:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-29 11:29 [PATCH] drivers/base/node: Avoid manual device_create_file() calls Takashi Iwai
2015-01-29 14:35 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150129143548.GA9723@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox