From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759142AbbA3AxI (ORCPT ); Thu, 29 Jan 2015 19:53:08 -0500 Received: from e38.co.us.ibm.com ([32.97.110.159]:57219 "EHLO e38.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753906AbbA3AxF (ORCPT ); Thu, 29 Jan 2015 19:53:05 -0500 Date: Thu, 29 Jan 2015 16:52:02 -0800 From: "Paul E. McKenney" To: kbuild test robot Cc: kbuild-all@01.org, Ingo Molnar , Peter Zijlstra , linux-kernel@vger.kernel.org Subject: Re: [PATCH rcu] cpu: __pcpu_scope_cpu_dead_idle can be static Message-ID: <20150130005202.GK19109@linux.vnet.ibm.com> Reply-To: paulmck@linux.vnet.ibm.com References: <201501300853.V9uY1YIW%fengguang.wu@intel.com> <20150130004307.GA56141@snb> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150130004307.GA56141@snb> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15013000-0029-0000-0000-0000078F6141 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 30, 2015 at 08:43:07AM +0800, kbuild test robot wrote: > kernel/sched/idle.c:184:1: sparse: symbol '__pcpu_scope_cpu_dead_idle' was not declared. Should it be static? > > Signed-off-by: Fengguang Wu It cannot be static, as it is used in kernel/cpu.c. But it sounds like sparse would be happier if the DECLARE_PER_CPU() was visible in kernel/sched/idle.c. Which would allow the compiler to catch certain kinds of typos, now that I think about it. Or am I missing something here? Thanx, Paul > --- > idle.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/sched/idle.c b/kernel/sched/idle.c > index 42b5102..41354cd 100644 > --- a/kernel/sched/idle.c > +++ b/kernel/sched/idle.c > @@ -181,7 +181,7 @@ exit_idle: > start_critical_timings(); > } > > -DEFINE_PER_CPU(bool, cpu_dead_idle); > +static DEFINE_PER_CPU(bool, cpu_dead_idle); > > /* > * Generic idle loop implementation >