From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759957AbbA3IuL (ORCPT ); Fri, 30 Jan 2015 03:50:11 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:46978 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752637AbbA3IuJ (ORCPT ); Fri, 30 Jan 2015 03:50:09 -0500 Date: Fri, 30 Jan 2015 11:49:40 +0300 From: Dan Carpenter To: QLogic-Storage-Upstream@qlogic.com Cc: "James E.J. Bottomley" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [patch] bnx2fc: fix test of "err_warn_bit_map" Message-ID: <20150130084940.GF21357@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: ucsinet21.oracle.com [156.151.31.93] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The bug in this code is "if (err_warn_bit_map & (u64) (1 << i)) {". The cast to u64 happens after we have already shift wrapped so it's too late. Presumably this means some warnings are ignored. I also cleanup the other err_warn_bit_map check. Signed-off-by: Dan Carpenter --- Not tested. diff --git a/drivers/scsi/bnx2fc/bnx2fc_hwi.c b/drivers/scsi/bnx2fc/bnx2fc_hwi.c index c6688d7..a0cb702 100644 --- a/drivers/scsi/bnx2fc/bnx2fc_hwi.c +++ b/drivers/scsi/bnx2fc/bnx2fc_hwi.c @@ -734,7 +734,7 @@ static void bnx2fc_process_unsol_compl(struct bnx2fc_rport *tgt, u16 wqe) ((u64)err_entry->data.err_warn_bitmap_hi << 32) | (u64)err_entry->data.err_warn_bitmap_lo; for (i = 0; i < BNX2FC_NUM_ERR_BITS; i++) { - if (err_warn_bit_map & (u64)((u64)1 << i)) { + if (err_warn_bit_map & 1ULL << i) { err_warn = i; break; } @@ -829,7 +829,7 @@ ret_err_rqe: ((u64)err_entry->data.err_warn_bitmap_hi << 32) | (u64)err_entry->data.err_warn_bitmap_lo; for (i = 0; i < BNX2FC_NUM_ERR_BITS; i++) { - if (err_warn_bit_map & (u64) (1 << i)) { + if (err_warn_bit_map & 1ULL << i) { err_warn = i; break; }