From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1762036AbbA3MrK (ORCPT <rfc822;w@1wt.eu>);
	Fri, 30 Jan 2015 07:47:10 -0500
Received: from mx1.redhat.com ([209.132.183.28]:35928 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1759268AbbA3MrI (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Fri, 30 Jan 2015 07:47:08 -0500
Date: Fri, 30 Jan 2015 13:45:50 +0100
From: Oleg Nesterov <oleg@redhat.com>
To: Dave Hansen <dave.hansen@linux.intel.com>
Cc: Rik van Riel <riel@redhat.com>, Suresh Siddha <sbsiddha@gmail.com>,
        Andy Lutomirski <luto@amacapital.net>,
        Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
        "H. Peter Anvin" <hpa@zytor.com>, Fenghua Yu <fenghua.yu@intel.com>,
        the arch/x86 maintainers <x86@kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/3]: x86, fpu: unlazy_fpu fixes/cleanups
Message-ID: <20150130124550.GA4551@redhat.com>
References: <54C2A245.4010307@redhat.com> <20150129210723.GA31584@redhat.com> <54CAA357.1070108@linux.intel.com> <20150129213346.GA32511@redhat.com> <54CAA973.4050401@linux.intel.com> <20150129215638.GB1045@redhat.com> <54CAC190.30905@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <54CAC190.30905@linux.intel.com>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 01/29, Dave Hansen wrote:
>
> On 01/29/2015 01:56 PM, Oleg Nesterov wrote:
> > --- x/arch/x86/kernel/traps.c
> > +++ x/arch/x86/kernel/traps.c
> > @@ -313,7 +313,7 @@ dotraplinkage void do_bounds(struct pt_r
> >  	 * It is not directly accessible, though, so we need to
> >  	 * do an xsave and then pull it out of the xsave buffer.
> >  	 */
> > -	fpu_save_init(&tsk->thread.fpu);
> > +	unlazy_fpu(tsk);
> >  	xsave_buf = &(tsk->thread.fpu.state->xsave);
> ...
> > 	bndcsr = get_xsave_addr(xsave_buf, XSTATE_BNDCSR);
>
> Hmm, if the the thread was not using the FPU, and this fails to save
> anything in to the xsave_buf, what will bndcsr point to?  It _looks_ to
> me like it will just point to uninitialized data since the xsave never
> happened.
>
> Fenghua, shouldn't get_xsave_addr() be checking the xstate bit against
> the xsave->xstate_bv?

Can't really comment, but let me clarify what I meant just in case...

If it was not using FPU then I guess do_bounds() can't happen. However,
it can be preempted after conditional_sti(). fpu_save_init() is obviously
wrong unless __thread_has_fpu() == T, and this can be false if !eagerfpu
or if we add TIF_LOAD_FPU (defer FPU restore until return to userspace).

Oleg.