[PATCH] staging: media: lirc: lirc_zilog: Fix for possible null pointer dereference

Rickard Strandqvist
2015-01-29T18:44:51Z

Fix a possible null pointer dereference, there is
otherwise a risk of a possible null pointer dereference.

This was found using a static code analysis program called cppcheck

Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
---
drivers/staging/media/lirc/lirc_zilog.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/staging/media/lirc/lirc_zilog.c b/drivers/staging/media/lirc/lirc_zilog.c
index cc872fb..78ce3b0 100644
--- a/drivers/staging/media/lirc/lirc_zilog.c
+++ b/drivers/staging/media/lirc/lirc_zilog.c
@@ -1332,10 +1332,8 @@ static int close(struct inode *node, struct file *filep)
/* find our IR struct */
struct IR *ir = filep->private_data;

- if (ir == NULL) {
- dev_err(ir->l.dev, "close: no private_data attached to the file!\n");
+ if (ir == NULL)
return -ENODEV;
- }

atomic_dec(&ir->open_count);

--
1.7.10.4