From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763132AbbA3USx (ORCPT ); Fri, 30 Jan 2015 15:18:53 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:28503 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752629AbbA3USv (ORCPT ); Fri, 30 Jan 2015 15:18:51 -0500 Date: Fri, 30 Jan 2015 23:18:31 +0300 From: Dan Carpenter To: Rickard Strandqvist Cc: Ian Abbott , H Hartley Sweeten , devel@driverdev.osuosl.org, Chase Southwood , Conrad Meyer , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Fred Akers Subject: Re: [PATCH] staging: comedi: drivers: addi-data: hwdrv_apci1500: Change variables that is never used Message-ID: <20150130201831.GM6507@mwanda> References: <1422481377-31112-1-git-send-email-rickard_strandqvist@spectrumdigital.se> <20150130132647.GA6456@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150130132647.GA6456@mwanda> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: ucsinet21.oracle.com [156.151.31.93] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Richard, asked some questions out of band. I like these patches where they can remove the whole line. I don't like them where they leave stray, unneeded function calls. Or if we know that we need the function calls then I like those. Also when it comes to the point where we move this code out of staging then we can look at these warnings again. Normally people are good at fixing up any remaining static checker warnings at the end. (Except for binder, obviously. Binder didn't clean up anything. It's maintained by a mailing list which has yet to add itself to MAINTAINERS. Stupid binder mailing list). regards, dan carpenter