From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759883AbbA3UZz (ORCPT ); Fri, 30 Jan 2015 15:25:55 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:46451 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752400AbbA3UZx (ORCPT ); Fri, 30 Jan 2015 15:25:53 -0500 Date: Fri, 30 Jan 2015 12:25:53 -0800 From: Greg Kroah-Hartman To: Dan Carpenter Cc: Rickard Strandqvist , Ian Abbott , H Hartley Sweeten , devel@driverdev.osuosl.org, Chase Southwood , Conrad Meyer , linux-kernel@vger.kernel.org, Fred Akers Subject: Re: [PATCH] staging: comedi: drivers: addi-data: hwdrv_apci1500: Change variables that is never used Message-ID: <20150130202553.GA18072@kroah.com> References: <1422481377-31112-1-git-send-email-rickard_strandqvist@spectrumdigital.se> <20150130132647.GA6456@mwanda> <20150130201831.GM6507@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150130201831.GM6507@mwanda> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 30, 2015 at 11:18:31PM +0300, Dan Carpenter wrote: > Richard, asked some questions out of band. > > I like these patches where they can remove the whole line. I don't like > them where they leave stray, unneeded function calls. Or if we know > that we need the function calls then I like those. > > Also when it comes to the point where we move this code out of staging > then we can look at these warnings again. Normally people are good at > fixing up any remaining static checker warnings at the end. (Except for > binder, obviously. Binder didn't clean up anything. It's maintained by > a mailing list which has yet to add itself to MAINTAINERS. Stupid > binder mailing list). What remaining issues were in the binder code? And I have a non-mailing-list MAINTAINERS entry for binder in linux-next, it will go to Linus in a few hours. thanks, greg k-h