From: Dan Carpenter <dan.carpenter@oracle.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>,
Ian Abbott <abbotti@mev.co.uk>,
H Hartley Sweeten <hsweeten@visionengravers.com>,
devel@driverdev.osuosl.org,
Chase Southwood <chase.southwood@gmail.com>,
Conrad Meyer <cemeyer@uw.edu>,
linux-kernel@vger.kernel.org, Fred Akers <knivey@botops.net>
Subject: Re: [PATCH] staging: comedi: drivers: addi-data: hwdrv_apci1500: Change variables that is never used
Date: Sat, 31 Jan 2015 00:10:05 +0300 [thread overview]
Message-ID: <20150130211005.GN6507@mwanda> (raw)
In-Reply-To: <20150130202553.GA18072@kroah.com>
On Fri, Jan 30, 2015 at 12:25:53PM -0800, Greg Kroah-Hartman wrote:
> On Fri, Jan 30, 2015 at 11:18:31PM +0300, Dan Carpenter wrote:
> > Richard, asked some questions out of band.
> >
> > I like these patches where they can remove the whole line. I don't like
> > them where they leave stray, unneeded function calls. Or if we know
> > that we need the function calls then I like those.
> >
> > Also when it comes to the point where we move this code out of staging
> > then we can look at these warnings again. Normally people are good at
> > fixing up any remaining static checker warnings at the end. (Except for
> > binder, obviously. Binder didn't clean up anything. It's maintained by
> > a mailing list which has yet to add itself to MAINTAINERS. Stupid
> > binder mailing list).
>
> What remaining issues were in the binder code? And I have a
> non-mailing-list MAINTAINERS entry for binder in linux-next, it will go
> to Linus in a few hours.
>
Oh. Hm... I looked at it again and it's not as bad as I remember. I
appologize. I did have a question but I'll take it to another thread.
regards,
dan carpenter
next prev parent reply other threads:[~2015-01-30 21:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-28 21:42 [PATCH] staging: comedi: drivers: addi-data: hwdrv_apci1500: Change variables that is never used Rickard Strandqvist
2015-01-28 21:44 ` Rickard Strandqvist
2015-01-30 13:26 ` Dan Carpenter
2015-01-30 20:18 ` Dan Carpenter
2015-01-30 20:25 ` Greg Kroah-Hartman
2015-01-30 21:10 ` Dan Carpenter [this message]
2015-01-31 13:55 ` Rickard Strandqvist
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150130211005.GN6507@mwanda \
--to=dan.carpenter@oracle.com \
--cc=abbotti@mev.co.uk \
--cc=cemeyer@uw.edu \
--cc=chase.southwood@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hsweeten@visionengravers.com \
--cc=knivey@botops.net \
--cc=linux-kernel@vger.kernel.org \
--cc=rickard_strandqvist@spectrumdigital.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox