From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1760602AbbA3VKR (ORCPT <rfc822;w@1wt.eu>);
	Fri, 30 Jan 2015 16:10:17 -0500
Received: from userp1040.oracle.com ([156.151.31.81]:50861 "EHLO
	userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752169AbbA3VKQ (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 30 Jan 2015 16:10:16 -0500
Date: Sat, 31 Jan 2015 00:10:05 +0300
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>,
        Ian Abbott <abbotti@mev.co.uk>,
        H Hartley Sweeten <hsweeten@visionengravers.com>,
        devel@driverdev.osuosl.org,
        Chase Southwood <chase.southwood@gmail.com>,
        Conrad Meyer <cemeyer@uw.edu>, linux-kernel@vger.kernel.org,
        Fred Akers <knivey@botops.net>
Subject: Re: [PATCH] staging: comedi: drivers: addi-data: hwdrv_apci1500:
 Change variables that is never used
Message-ID: <20150130211005.GN6507@mwanda>
References: <1422481377-31112-1-git-send-email-rickard_strandqvist@spectrumdigital.se>
 <20150130132647.GA6456@mwanda>
 <20150130201831.GM6507@mwanda>
 <20150130202553.GA18072@kroah.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150130202553.GA18072@kroah.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-Source-IP: ucsinet21.oracle.com [156.151.31.93]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jan 30, 2015 at 12:25:53PM -0800, Greg Kroah-Hartman wrote:
> On Fri, Jan 30, 2015 at 11:18:31PM +0300, Dan Carpenter wrote:
> > Richard, asked some questions out of band.
> > 
> > I like these patches where they can remove the whole line.  I don't like
> > them where they leave stray, unneeded function calls.  Or if we know
> > that we need the function calls then I like those.
> > 
> > Also when it comes to the point where we move this code out of staging
> > then we can look at these warnings again.  Normally people are good at
> > fixing up any remaining static checker warnings at the end.  (Except for
> > binder, obviously.  Binder didn't clean up anything.  It's maintained by
> > a mailing list which has yet to add itself to MAINTAINERS.  Stupid
> > binder mailing list).
> 
> What remaining issues were in the binder code?  And I have a
> non-mailing-list MAINTAINERS entry for binder in linux-next, it will go
> to Linus in a few hours.
> 

Oh.  Hm...  I looked at it again and it's not as bad as I remember.  I
appologize.  I did have a question but I'll take it to another thread.

regards,
dan carpenter