From: Greg KH <gregkh@linuxfoundation.org>
To: Tim Chen <tim.c.chen@linux.intel.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
Akinobu Mita <akinobu.mita@gmail.com>,
Mathias Nyman <mathias.nyman@linux.intel.com>,
Andi Kleen <andi@firstfloor.org>, Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org, x86@kernel.org,
linux-usb@vger.kernel.org
Subject: Re: [PATCH] pci-dma: Fix x86 dma_alloc_coherent to fully clear all pages returned
Date: Fri, 30 Jan 2015 14:07:47 -0800 [thread overview]
Message-ID: <20150130220747.GA21792@kroah.com> (raw)
In-Reply-To: <1422655318.9530.15.camel@schen9-desk2.jf.intel.com>
On Fri, Jan 30, 2015 at 02:01:58PM -0800, Tim Chen wrote:
> On Fri, 2015-01-30 at 11:58 -0800, Greg KH wrote:
>
> >
> > Shouldn't this go to stable trees too?
> >
>
> Yes. Added the stable tag in updated patch that's resent.
>
> > Also, why is the xhci driver not asking for the memory it is going to
> > need? If it wants to use the full page, shouldn't it ask for it?
> >
>
> I agree that xhci should have done that, but it didn't. Commit
> d92ef66c4f8f ("x86: make dma_alloc_coherent() return zeroed memory
> if CMA is enabled") changed the behavior of dma_alloc_coherent
> by clearing only the memory being asked for.
>
> So for backward compatibility, clearing the pages
> completely to revert to dma_alloc_coherent's original
> behavior is probably the safe thing to do.
We don't "need" any backward compatility, why not fix the broken drivers
that are using memory outside of what they are asking for? That's not
ok no matter what, right?
thanks,
greg k-h
next prev parent reply other threads:[~2015-01-30 22:07 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-30 19:54 [PATCH] pci-dma: Fix x86 dma_alloc_coherent to fully clear all pages returned Tim Chen
2015-01-30 19:58 ` Greg KH
2015-01-30 22:01 ` Tim Chen
2015-01-30 22:07 ` Greg KH [this message]
2015-01-30 22:16 ` Tim Chen
2015-01-30 22:39 ` Andi Kleen
2015-01-31 17:14 ` Alan Stern
2015-01-30 21:03 ` Sergei Shtylyov
2015-01-30 21:54 ` Tim Chen
2015-02-02 14:02 ` Jiri Slaby
2015-02-02 16:39 ` Sergei Shtylyov
2015-02-04 18:30 ` Tim Chen
2015-02-18 19:40 ` Tim Chen
2015-02-18 19:53 ` Alan Stern
2015-02-18 20:19 ` Tim Chen
2015-02-18 20:36 ` Greg Kroah-Hartman
2015-02-18 20:39 ` Andi Kleen
2015-02-18 21:15 ` Alan Stern
2015-02-18 20:45 ` Alan Stern
2015-02-18 23:59 ` Tim Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150130220747.GA21792@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=akinobu.mita@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mathias.nyman@linux.intel.com \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=tim.c.chen@linux.intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox