From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757027AbbAaBST (ORCPT ); Fri, 30 Jan 2015 20:18:19 -0500 Received: from mail-pa0-f46.google.com ([209.85.220.46]:60637 "EHLO mail-pa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752871AbbAaBSR convert rfc822-to-8bit (ORCPT ); Fri, 30 Jan 2015 20:18:17 -0500 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT From: Mike Turquette User-Agent: alot/0.3.5 To: Stephen Boyd , linux-kernel@vger.kernel.org References: <1422653113-32688-1-git-send-email-mturquette@linaro.org> <1422653113-32688-4-git-send-email-mturquette@linaro.org> <54CC185E.9010007@codeaurora.org> In-Reply-To: <54CC185E.9010007@codeaurora.org> Message-ID: <20150131011801.22722.60852@quantum> Subject: Re: [PATCH 3/3] clk: remove clk-private.h Date: Fri, 30 Jan 2015 17:18:01 -0800 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Stephen Boyd (2015-01-30 15:48:46) > On 01/30/15 13:25, Michael Turquette wrote: > > Private clock framework data structures should be private, surprisingly. > > > > Now that all platforms and drivers have been updated to remove static > > initializations of struct clk and struct clk_core objects and all > > references to clk-private.h have been removed we can move the > > definitions of these structures into drivers/clk/clk.c and delete the > > header. > > > > Additionally the ugly DEFINE_CLK macros have been removed. Those were > > used for static definitions of struct clk objects. That practice is no > > longer allowed. > > > > Signed-off-by: Michael Turquette > > This is great! > > Reviewed-by: Stephen Boyd > > given the minor comment below. > > > - * Returns 0 on success, otherwise an error code. > > - */ > > -int __clk_init(struct device *dev, struct clk *clk); > > Shouldn't __clk_init become static now in clk.c? Good catch! Regards, Mike > > -- > Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, > a Linux Foundation Collaborative Project >