From: Dan Carpenter <dan.carpenter@oracle.com>
To: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Larry Finger <Larry.Finger@lwfinger.net>,
devel@driverdev.osuosl.org, Jia He <hejianet@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8188eu: core: rtw_sta_mgt: Removed variables that is never used
Date: Sat, 31 Jan 2015 19:19:57 +0300 [thread overview]
Message-ID: <20150131161957.GF6456@mwanda> (raw)
In-Reply-To: <1422715533-915-1-git-send-email-rickard_strandqvist@spectrumdigital.se>
On Sat, Jan 31, 2015 at 03:45:33PM +0100, Rickard Strandqvist wrote:
> while (phead != plist) {
> - psta = container_of(plist, struct sta_info , list);
> + container_of(plist, struct sta_info, list);
Argh!!! No.
For this one, I didn't need an context to see that it was wrong, so I
accidentally reviewed it instead of just marking it as read.
regards,
dan carpenter
next prev parent reply other threads:[~2015-01-31 16:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-31 14:45 [PATCH] staging: rtl8188eu: core: rtw_sta_mgt: Removed variables that is never used Rickard Strandqvist
2015-01-31 16:19 ` Dan Carpenter [this message]
2015-01-31 17:41 ` Larry Finger
2015-02-01 4:21 ` Greg Kroah-Hartman
2015-02-01 4:20 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150131161957.GF6456@mwanda \
--to=dan.carpenter@oracle.com \
--cc=Larry.Finger@lwfinger.net \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hejianet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rickard_strandqvist@spectrumdigital.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox