From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754740AbbAaQUC (ORCPT ); Sat, 31 Jan 2015 11:20:02 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:46791 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752095AbbAaQUA (ORCPT ); Sat, 31 Jan 2015 11:20:00 -0500 Date: Sat, 31 Jan 2015 19:19:57 +0300 From: Dan Carpenter To: Rickard Strandqvist Cc: Greg Kroah-Hartman , Larry Finger , devel@driverdev.osuosl.org, Jia He , linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: rtl8188eu: core: rtw_sta_mgt: Removed variables that is never used Message-ID: <20150131161957.GF6456@mwanda> References: <1422715533-915-1-git-send-email-rickard_strandqvist@spectrumdigital.se> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1422715533-915-1-git-send-email-rickard_strandqvist@spectrumdigital.se> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: ucsinet21.oracle.com [156.151.31.93] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jan 31, 2015 at 03:45:33PM +0100, Rickard Strandqvist wrote: > while (phead != plist) { > - psta = container_of(plist, struct sta_info , list); > + container_of(plist, struct sta_info, list); Argh!!! No. For this one, I didn't need an context to see that it was wrong, so I accidentally reviewed it instead of just marking it as read. regards, dan carpenter