From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754197AbbAaQq7 (ORCPT <rfc822;w@1wt.eu>);
	Sat, 31 Jan 2015 11:46:59 -0500
Received: from userp1040.oracle.com ([156.151.31.81]:42721 "EHLO
	userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753549AbbAaQq6 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sat, 31 Jan 2015 11:46:58 -0500
Date: Sat, 31 Jan 2015 19:46:48 +0300
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Bhuvanchandra DV <bhuvanchandra.dv@toradex.com>
Cc: broonie@kernel.org, stefan@agner.ch, linux-spi@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] spi: fsl-dspi: Remove possible memory leak of 'chip'
Message-ID: <20150131164648.GR6507@mwanda>
References: <1422722005-1616-1-git-send-email-bhuvanchandra.dv@toradex.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1422722005-1616-1-git-send-email-bhuvanchandra.dv@toradex.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-Source-IP: ucsinet22.oracle.com [156.151.31.94]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, Jan 31, 2015 at 10:03:25PM +0530, Bhuvanchandra DV wrote:
> Move the check for spi->bits_per_word
> before allocation, to avoid memory leak.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Normally, you would give me a Reported-by: tag.  Not a big deal either
way.

> Signed-off-by: Bhuvanchandra DV <bhuvanchandra.dv@toradex.com>

regards,
dan carpenter