From: Tejun Heo <tj@kernel.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Hans de Goede <hdegoede@redhat.com>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
Gregory CLEMENT <gregory.clement@free-electrons.com>
Subject: Re: [PATCH] ata: libahci: Use of_platform_device_create only if supported
Date: Sat, 31 Jan 2015 12:08:12 -0500 [thread overview]
Message-ID: <20150131170812.GC3088@htj.dyndns.org> (raw)
In-Reply-To: <54CD0890.7050800@roeck-us.net>
On Sat, Jan 31, 2015 at 08:53:36AM -0800, Guenter Roeck wrote:
> I agree, it is weird, as is the whole "all API functions associated
> with OF_ADDRESS are handled differently on sparc" thing. But that
> is neither new nor something I can fix.
Out of curiousity, why isn't the header file doing the following?
#ifdef CONFIG_OF_ADDRESS
void of_platform_device_create(blah);
...
#else
static inline void of_platform_device_create(blah)
{
}
#endif
--
tejun
next prev parent reply other threads:[~2015-01-31 17:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-31 16:32 [PATCH] ata: libahci: Use of_platform_device_create only if supported Guenter Roeck
2015-01-31 16:34 ` Hans de Goede
2015-01-31 16:45 ` Tejun Heo
2015-01-31 16:53 ` Guenter Roeck
2015-01-31 17:08 ` Tejun Heo [this message]
2015-01-31 17:33 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150131170812.GC3088@htj.dyndns.org \
--to=tj@kernel.org \
--cc=gregory.clement@free-electrons.com \
--cc=hdegoede@redhat.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox