From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755794AbbAaUku (ORCPT ); Sat, 31 Jan 2015 15:40:50 -0500 Received: from mail-pa0-f54.google.com ([209.85.220.54]:35178 "EHLO mail-pa0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753684AbbAaUks (ORCPT ); Sat, 31 Jan 2015 15:40:48 -0500 Date: Sat, 31 Jan 2015 12:40:44 -0800 From: Jeremiah Mahler To: chowdegowda.ms@smartplayin.com Cc: linux-kernel@vger.kernel.org, pramod.gurav@smartplayin.com, kiran.padwal@smartplayin.com Subject: Re: [PATCH] lustre:include:linux:libcfs:libcfs_private.h:fixes the duplicate case value issue. Message-ID: <20150131204044.GA3586@hudson.localdomain> Mail-Followup-To: Jeremiah Mahler , chowdegowda.ms@smartplayin.com, linux-kernel@vger.kernel.org, pramod.gurav@smartplayin.com, kiran.padwal@smartplayin.com References: <1422613549-30681-1-git-send-email-chowdegowda.ms@smartplayin.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1422613549-30681-1-git-send-email-chowdegowda.ms@smartplayin.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 30, 2015 at 03:55:49PM +0530, chowdegowda.ms@smartplayin.com wrote: > From: Chowdegowda > There are a lot of problems with this patch. First, is "Chowdegowda" your full name that you would use to sign legal documents? In your Subject line Subject: [PATCH] lustre:include:linux:libcfs:libcfs_private.h:fixes the you are using far too many tags. The path to the file is not necessary since this can be deduced from the patch. In this case I might use "staging: lustre:". If you want a crash course in submitting patches I recommend watching Greg Kroah-Hartman's presentation on how to write and submit your first Linux kernel patch [1]. [1]: https://www.youtube.com/watch?v=LLBrBBImJt4 -- - Jeremiah Mahler