public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Derrick Greenspan <derrick.greenspan@knights.ucf.edu>
Cc: Malcolm Priestley <tvboxspy@gmail.com>,
	Forest Bond <forest@alittletooquiet.net>,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCHv3] staging: vt6656: removed erroneous else statement
Date: Sat, 31 Jan 2015 17:09:24 -0800	[thread overview]
Message-ID: <20150201010924.GA25164@kroah.com> (raw)
In-Reply-To: <1422731121-5560-1-git-send-email-derrick.greenspan@knights.ucf.edu>

On Sat, Jan 31, 2015 at 02:05:21PM -0500, Derrick Greenspan wrote:
> This patch fixes the checkpatch.pl warning:
> 
> WARNING: else is not generally useful after a break or return
> 559: FILE: drivers/staging/vt6656/rxtx.c:559:
> return vnt_rxtx_datahead_g_fb(tx_context, &buf->data_head);
> } else {
> 
> Signed-off-by: Derrick Greenspan <derrick.greenspan@knights.ucf.edu>
> ---
> Changes in v2:
>  - Hopefully fixed whitespace!
> Changes in v3:
>  - Fixed GCC compiler warning

I don't believe you really did fix that warning, as you still are
creating a variable in the middle of a function, which isn't allowed.

Just leave the existing code as-is, this is getting too messy.

thanks,

greg k-h

      parent reply	other threads:[~2015-02-01  1:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-31 19:05 [PATCHv3] staging: vt6656: removed erroneous else statement Derrick Greenspan
2015-01-31 22:31 ` Malcolm Priestley
2015-02-01  1:09 ` Greg Kroah-Hartman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150201010924.GA25164@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=derrick.greenspan@knights.ucf.edu \
    --cc=devel@driverdev.osuosl.org \
    --cc=forest@alittletooquiet.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tvboxspy@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox