From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753878AbbBABJ0 (ORCPT ); Sat, 31 Jan 2015 20:09:26 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:57065 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751605AbbBABJZ (ORCPT ); Sat, 31 Jan 2015 20:09:25 -0500 Date: Sat, 31 Jan 2015 17:09:24 -0800 From: Greg Kroah-Hartman To: Derrick Greenspan Cc: Malcolm Priestley , Forest Bond , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCHv3] staging: vt6656: removed erroneous else statement Message-ID: <20150201010924.GA25164@kroah.com> References: <1422731121-5560-1-git-send-email-derrick.greenspan@knights.ucf.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1422731121-5560-1-git-send-email-derrick.greenspan@knights.ucf.edu> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jan 31, 2015 at 02:05:21PM -0500, Derrick Greenspan wrote: > This patch fixes the checkpatch.pl warning: > > WARNING: else is not generally useful after a break or return > 559: FILE: drivers/staging/vt6656/rxtx.c:559: > return vnt_rxtx_datahead_g_fb(tx_context, &buf->data_head); > } else { > > Signed-off-by: Derrick Greenspan > --- > Changes in v2: > - Hopefully fixed whitespace! > Changes in v3: > - Fixed GCC compiler warning I don't believe you really did fix that warning, as you still are creating a variable in the middle of a function, which isn't allowed. Just leave the existing code as-is, this is getting too messy. thanks, greg k-h