Re: [PATCH] staging: rtl8188eu: core: rtw_sta_mgt: Removed variables that is never used

[Greg Kroah-Hartman <gregkh@linuxfoundation.org>]

On Sat, Jan 31, 2015 at 03:45:33PM +0100, Rickard Strandqvist wrote:
> Variable was assigned a value that was never used.
> I have also removed all the code that thereby serves no purpose.
> 
> This was found using a static code analysis program called cppcheck
> 
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> ---
>  drivers/staging/rtl8188eu/core/rtw_sta_mgt.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c b/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c
> index dc9d0dd..1e737ed 100644
> --- a/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c
> +++ b/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c
> @@ -149,7 +149,6 @@ inline struct sta_info *rtw_get_stainfo_by_offset(struct sta_priv *stapriv, int
>  static void rtw_mfree_all_stainfo(struct sta_priv *pstapriv)
>  {
>  	struct list_head *plist, *phead;
> -	struct sta_info *psta = NULL;
>  
>  
>  	spin_lock_bh(&pstapriv->sta_hash_lock);
> @@ -158,7 +157,7 @@ static void rtw_mfree_all_stainfo(struct sta_priv *pstapriv)
>  	plist = phead->next;
>  
>  	while (phead != plist) {
> -		psta = container_of(plist, struct sta_info , list);
> +		container_of(plist, struct sta_info, list);

How did this patch even compile?

{sigh}