From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753185AbbBAEgd (ORCPT ); Sat, 31 Jan 2015 23:36:33 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:57901 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752874AbbBAEg3 (ORCPT ); Sat, 31 Jan 2015 23:36:29 -0500 Date: Sat, 31 Jan 2015 20:20:47 -0800 From: Greg Kroah-Hartman To: Rickard Strandqvist Cc: Larry Finger , devel@driverdev.osuosl.org, Jia He , linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: rtl8188eu: core: rtw_sta_mgt: Removed variables that is never used Message-ID: <20150201042047.GB25151@kroah.com> References: <1422715533-915-1-git-send-email-rickard_strandqvist@spectrumdigital.se> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1422715533-915-1-git-send-email-rickard_strandqvist@spectrumdigital.se> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jan 31, 2015 at 03:45:33PM +0100, Rickard Strandqvist wrote: > Variable was assigned a value that was never used. > I have also removed all the code that thereby serves no purpose. > > This was found using a static code analysis program called cppcheck > > Signed-off-by: Rickard Strandqvist > --- > drivers/staging/rtl8188eu/core/rtw_sta_mgt.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c b/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c > index dc9d0dd..1e737ed 100644 > --- a/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c > +++ b/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c > @@ -149,7 +149,6 @@ inline struct sta_info *rtw_get_stainfo_by_offset(struct sta_priv *stapriv, int > static void rtw_mfree_all_stainfo(struct sta_priv *pstapriv) > { > struct list_head *plist, *phead; > - struct sta_info *psta = NULL; > > > spin_lock_bh(&pstapriv->sta_hash_lock); > @@ -158,7 +157,7 @@ static void rtw_mfree_all_stainfo(struct sta_priv *pstapriv) > plist = phead->next; > > while (phead != plist) { > - psta = container_of(plist, struct sta_info , list); > + container_of(plist, struct sta_info, list); How did this patch even compile? {sigh}