From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753476AbbBAOWA (ORCPT ); Sun, 1 Feb 2015 09:22:00 -0500 Received: from down.free-electrons.com ([37.187.137.238]:40109 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753339AbbBAOVy (ORCPT ); Sun, 1 Feb 2015 09:21:54 -0500 Date: Sun, 1 Feb 2015 15:17:50 +0100 From: Maxime Ripard To: Chen-Yu Tsai Cc: Mike Turquette , Emilio Lopez , Rob Herring , Grant Likely , Kishon Vijay Abraham I , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com Subject: Re: [PATCH v3 06/10] ARM: dts: sun9i: Add USB host controller nodes to a80 dtsi Message-ID: <20150201141750.GG4827@lukather> References: <1422388455-25923-1-git-send-email-wens@csie.org> <1422388455-25923-7-git-send-email-wens@csie.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="S5HS5MvDw4DmbRmb" Content-Disposition: inline In-Reply-To: <1422388455-25923-7-git-send-email-wens@csie.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --S5HS5MvDw4DmbRmb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jan 28, 2015 at 03:54:11AM +0800, Chen-Yu Tsai wrote: > The A80 has 3 EHCI/OHCI USB controllers. >=20 > Signed-off-by: Chen-Yu Tsai > --- > arch/arm/boot/dts/sun9i-a80.dtsi | 70 ++++++++++++++++++++++++++++++++++= ++++++ > 1 file changed, 70 insertions(+) >=20 > diff --git a/arch/arm/boot/dts/sun9i-a80.dtsi b/arch/arm/boot/dts/sun9i-a= 80.dtsi > index d7ebd9390b01..9483b15bfda7 100644 > --- a/arch/arm/boot/dts/sun9i-a80.dtsi > +++ b/arch/arm/boot/dts/sun9i-a80.dtsi > @@ -355,6 +355,28 @@ > */ > ranges =3D <0 0 0 0x20000000>; > =20 > + ehci0: usb@00a00000 { > + compatible =3D "allwinner,sun9i-a80-ehci", "generic-ehci"; > + reg =3D <0x00a00000 0x100>; > + interrupts =3D ; > + clocks =3D <&usb_mod_clk 1>; > + resets =3D <&usb_mod_clk 17>; > + phys =3D <&usbphy1>; > + phy-names =3D "usb"; > + status =3D "disabled"; > + }; > + > + ohci0: usb@00a00400 { > + compatible =3D "allwinner,sun9i-a80-ohci", "generic-ohci"; > + reg =3D <0x00a00400 0x100>; > + interrupts =3D ; > + clocks =3D <&usb_mod_clk 1>, <&usb_mod_clk 2>; > + resets =3D <&usb_mod_clk 17>; > + phys =3D <&usbphy1>; > + phy-names =3D "usb"; > + status =3D "disabled"; > + }; > + > usbphy1: phy@00a00800 { > compatible =3D "allwinner,sun9i-a80-usb-phy"; > reg =3D <0x00a00800 0x4>; > @@ -366,6 +388,32 @@ > #phy-cells =3D <0>; > }; > =20 > + ehci1: usb@00a01000 { > + compatible =3D "allwinner,sun9i-a80-ehci", "generic-ehci"; > + reg =3D <0x00a01000 0x100>; > + interrupts =3D ; > + clocks =3D <&usb_mod_clk 3>; > + resets =3D <&usb_mod_clk 18>; > + phys =3D <&usbphy2>; > + phy-names =3D "usb"; > + status =3D "disabled"; > + }; > + > + /* > + * Even though ohci1 exists, it is never used as > + * usb1 only has HSIC pins routed externally > + */ > + ohci1: usb@00a01400 { > + compatible =3D "allwinner,sun9i-a80-ohci", "generic-ohci"; > + reg =3D <0x00a01400 0x100>; > + interrupts =3D ; > + clocks =3D <&usb_mod_clk 3>, <&usb_mod_clk 4>; > + resets =3D <&usb_mod_clk 18>; > + phys =3D <&usbphy2>; > + phy-names =3D "usb"; > + status =3D "disabled"; > + }; > + Is it worth declaring it then? If it's not never ever going to be used since no pins are routed outside of the SoC, I don't think it should be declared in the DTSI. Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --S5HS5MvDw4DmbRmb Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJUzjWNAAoJEBx+YmzsjxAgawQP/jONvIbHYlhVW8WHG1V5PF75 5UXhv+5OxwJk4u5PbDn0yJ90VO3HufEsQlB8SNk5ii5IHzdLCnvOuQLsHcg6Hk/R idTRtH+LBTR3S6wcmfngeQuZeTKdnAng1OQXwYn7Vx4QxRqxlclOBieMzSa+qcKl G0LEGZDGk9dzjncqWp27QA3WFxP9r24So0wKf2zP3F8GbSXOpqcI7AUiAd58Wk16 5Ox7ic+Kn7BMiIJDZHW0kKa9Dw7cMXfaJLu+kWDJYFgerxVO05Abt443BB4y2382 aAPUYLIlE8ABf+GIKPv2wAKE2cdIDdIKAzSOGViDcb3arFiLhPprOfNhFYEHFo9z klSQCaJjmzAhDN/BGDA8eIgrKAl7qgqSQJ1azMcStPty04R/2vX2yJSNERqETyfb 79kelhziIaRiCsdZmivzp2ZA0qy3IPcfFpm8VaJaqYb/GtigKIOFcUwAPY5QgXCF YrC5Jc9BMJ3F5flUUaLx3XnM7xGCZ9m8gAbRTBae5KTab+ZApFEBralpLy04Bsit Og6aCB54D3jmRvg97lpcQs9YLWCtIUypBAXM3NidmPwg2MSLmjNh1JS8PoZ9qWaz G45ve70aza3h5rznlAV3AAD2Aa8pVcHMWu8ELRgxWs0ItKpJCWmdKVSwDeLtO53k 6/WQmUxK6WjPprk5z0aQ =67Dv -----END PGP SIGNATURE----- --S5HS5MvDw4DmbRmb--