From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753483AbbBAO0I (ORCPT ); Sun, 1 Feb 2015 09:26:08 -0500 Received: from down.free-electrons.com ([37.187.137.238]:40166 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751448AbbBAO0F (ORCPT ); Sun, 1 Feb 2015 09:26:05 -0500 Date: Sun, 1 Feb 2015 15:20:07 +0100 From: Maxime Ripard To: Chen-Yu Tsai Cc: Mike Turquette , Emilio Lopez , Rob Herring , Grant Likely , Kishon Vijay Abraham I , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com Subject: Re: [PATCH v3 07/10] ARM: dts: sunxi: Add usb3_vbus regulator to common regulators dtsi Message-ID: <20150201142007.GH4827@lukather> References: <1422388455-25923-1-git-send-email-wens@csie.org> <1422388455-25923-8-git-send-email-wens@csie.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="0XhtP95kHFp3KGBe" Content-Disposition: inline In-Reply-To: <1422388455-25923-8-git-send-email-wens@csie.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --0XhtP95kHFp3KGBe Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jan 28, 2015 at 03:54:12AM +0800, Chen-Yu Tsai wrote: > Some SoCs have a total of 4 possible USB controllers. One such example > is the A80, which has one USB3 dual role device and 3 EHCI/OHCI pairs. >=20 > Add a common VBUS regulator for the last host controller. >=20 > Signed-off-by: Chen-Yu Tsai > --- > arch/arm/boot/dts/sunxi-common-regulators.dtsi | 10 ++++++++++ > 1 file changed, 10 insertions(+) >=20 > diff --git a/arch/arm/boot/dts/sunxi-common-regulators.dtsi b/arch/arm/bo= ot/dts/sunxi-common-regulators.dtsi > index e02baa66b33c..97fe8d73c4f7 100644 > --- a/arch/arm/boot/dts/sunxi-common-regulators.dtsi > +++ b/arch/arm/boot/dts/sunxi-common-regulators.dtsi > @@ -130,6 +130,16 @@ > status =3D "disabled"; > }; > =20 > + reg_usb3_vbus: usb3-vbus { > + compatible =3D "regulator-fixed"; > + pinctrl-names =3D "default"; > + regulator-name =3D "usb3-vbus"; > + regulator-min-microvolt =3D <5000000>; > + regulator-max-microvolt =3D <5000000>; > + enable-active-high; > + status =3D "disabled"; > + }; > + I don't think you replied to this one. What other SoC is using the USB3 regulator? Is it worth it to put it in there and bloat all the other DTS for something that is only used on a single board so far? Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --0XhtP95kHFp3KGBe Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJUzjYXAAoJEBx+YmzsjxAgVAEP/08ahlCsSC+XjzB3vAkBrC7D Sy7reVPvnu2B0aXU7rCrdbE6KmjDxQhw2c2m8UJcCbuADkcqYG5GjS1m16ng2bMJ DU59L/WDJ14jaPECOIa/OYfk3IFfDNRMRb4cQRta3p/ZjxY3usErHh9sT6FAE7/u 6/CBpXI+ReJ8F7BKeZoz/QJtsRh9Ke1zvTBbU6MH7ptJDdPptDnw0R07jHRRVKDb H3cdwDQtxnh+quPx3lkEAauLcUeYtYDB4oqmTjbeIhyzZoeh4KOg0+oW8aWb6vlR axgvMYMYIq2GWd5GXnJowK5kJec+mBDG3bajZgwe9lGT3G652X2XwTEQxwJuamJI AGSbRaMaIKJORCiBRSVRIMj3VS3SPajip8Cb17ydP8Mpf7gZ7yGUGUm+ws1oSz5a zkSuclCVveHxp5Rtxo4IC+NsDrFm969NwVhKJfb/kaE2Hqmhnjv5SmHGYATbga60 vRSsmgr5JBLeKXFQBaTj3a17n2ta1gnpbLJ84CQ/NBhAICM3f1RjTaF7f34ZueDk irzllTnV5Ht68jNxw8QbrjDVSa8tbLBVNHiQSw+AhOjgvHZV4n+L+q7MH2Ywg/Gi XsJlLwc57LMfr9EF8v++RT1PXYX/Ugt65TW/hyq6wC5mTDNp85wdBajpZcfASAxP IW7FNm4QYrEa2fiFy3f1 =RUOk -----END PGP SIGNATURE----- --0XhtP95kHFp3KGBe--