From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933264AbbBBNpV (ORCPT ); Mon, 2 Feb 2015 08:45:21 -0500 Received: from foss-mx-na.foss.arm.com ([217.140.108.86]:40589 "EHLO foss-mx-na.foss.arm.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1754680AbbBBNpU (ORCPT ); Mon, 2 Feb 2015 08:45:20 -0500 Date: Mon, 2 Feb 2015 13:45:12 +0000 From: Will Deacon To: "mathieu.poirier@linaro.org" Cc: Catalin Marinas , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 2/2] coresight: Adding coresight support to arm64 Message-ID: <20150202134512.GE31847@arm.com> References: <1422658466-23984-1-git-send-email-mathieu.poirier@linaro.org> <1422658466-23984-3-git-send-email-mathieu.poirier@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1422658466-23984-3-git-send-email-mathieu.poirier@linaro.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 30, 2015 at 10:54:26PM +0000, mathieu.poirier@linaro.org wrote: > From: Mathieu Poirier > > Aside from tracers, all currently supported coresight IP blocks > are 64 bit ready. As such add the required symbol definition to > compile the framework and drivers. > > Also fixing a couple of warnings picked up by the 64bit compiler. > > Signed-off-by: Mathieu Poirier > --- > arch/arm64/Kconfig.debug | 48 +++++++++++++++++++++++++++++++++++++ > drivers/coresight/coresight-etb10.c | 2 +- > drivers/coresight/coresight-tmc.c | 2 +- > 3 files changed, 50 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/Kconfig.debug b/arch/arm64/Kconfig.debug > index 5fdd6dce8061..77dfebbcbffe 100644 > --- a/arch/arm64/Kconfig.debug > +++ b/arch/arm64/Kconfig.debug > @@ -66,4 +66,52 @@ config DEBUG_SET_MODULE_RONX > against certain classes of kernel exploits. > If in doubt, say "N". > > +menuconfig CORESIGHT > + bool "CoreSight Tracing Support" > + select ARM_AMBA > + help > + This framework provides a kernel interface for the CoreSight debug > + and trace drivers to register themselves with. It's intended to build > + a topological view of the CoreSight components based on a DT > + specification and configure the right serie of components when a > + trace source gets enabled. Why does this need to be duplicated by each architecture wanting to make use of coresight capabilities defined under drivers/coresight? Can't we instead have this menuconfig and associated suboptions defined by a core Kconfig file, then have HAVE_ARCH_CORESIGHT_TRACE or something which can be selected by architectures wanting to make use of the framework? Will