From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753613AbbBBRLR (ORCPT ); Mon, 2 Feb 2015 12:11:17 -0500 Received: from smtp6.ore.mailhop.org ([54.149.35.133]:40154 "EHLO smtp6.ore.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751663AbbBBRLQ (ORCPT ); Mon, 2 Feb 2015 12:11:16 -0500 X-Mail-Handler: DuoCircle Outbound SMTP X-Originating-IP: 104.193.169.186 X-Report-Abuse-To: abuse@duocircle.com (see https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information for abuse reporting information) X-MHO-User: U2FsdGVkX1+p0Oc/eUoplKcodcmmkN8s Date: Mon, 2 Feb 2015 09:08:27 -0800 From: Tony Lindgren To: Roger Quadros Cc: Semen Protsenko , linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] ARM: OMAP2+: gpmc: Fix writing in gpmc_cs_set_memconf Message-ID: <20150202170827.GD9418@atomide.com> References: <1422131320-1018-1-git-send-email-semen.protsenko@globallogic.com> <54C60A3A.1090008@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <54C60A3A.1090008@ti.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Roger Quadros [150126 01:38]: > On 24/01/15 22:28, Semen Protsenko wrote: > > Some GPMC_CONFIG7 register bits marked as "RESERVED", means they > > shouldn't be overwritten. A typical approach to handle such bits called > > "Read-Modify-Write". Writing procedure used in gpmc_cs_set_memconf() > > utilizes RMW technique, but implemented incorrectly. Due to obvious typo > > in code read register value is being rewritten by another value, which > > leads to loss of read RESERVED bits. This patch fixes this. > > > > While at it, replace magic numbers with named constants to improve code > > readability. > > > > Signed-off-by: Semen Protsenko > > This is much nicer. > > Acked-by: Roger Quadros Roger will queue this so: Acked-by: Tony Lindgren