From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932512AbbBCKPm (ORCPT ); Tue, 3 Feb 2015 05:15:42 -0500 Received: from mga09.intel.com ([134.134.136.24]:35057 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751202AbbBCKPi (ORCPT ); Tue, 3 Feb 2015 05:15:38 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,511,1418112000"; d="scan'208";a="660766218" Date: Tue, 3 Feb 2015 12:15:33 +0200 From: "mika.westerberg@linux.intel.com" To: Ken Xue Cc: "Rafael J. Wysocki" , "andy.shevchenko@gmail.com" , "linux-acpi@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH V2] acpi:apd:add AMD ACPI2Platform device support for x86 system. Message-ID: <20150203101533.GH1465@lahna.fi.intel.com> References: <1422870652.2528.6.camel@kxue-X58A-UD3R> <20150202130356.GS22740@lahna.fi.intel.com> <1422925495.2528.12.camel@kxue-X58A-UD3R> <20150203095307.GB1465@lahna.fi.intel.com> <1422957325.18208.13.camel@kxue-X58A-UD3R> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1422957325.18208.13.camel@kxue-X58A-UD3R> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 03, 2015 at 05:55:25PM +0800, Ken Xue wrote: > On Tue, 2015-02-03 at 11:53 +0200, mika.westerberg@linux.intel.com > wrote: > > On Tue, Feb 03, 2015 at 09:04:55AM +0800, Ken Xue wrote: > > > as you said, platform_drv_probe calls dev_pm_domain_attach(). but > > > platform_drv_probe just is a default probe routine. Not all platform > > > device drivers use this probe routine. so, codes here may be still > > > necessary. > > > > Are you saying that for platform devices there is some other path to get > > a driver probed, other than platform_drv_probe()? Can you point me to > > it? > >From the codes, i can see there is a possibility that drv->driver.probe > may not be set in __platform_driver_register. But i really can not point > out a use case that platform device driver without probe. > so, it is safe to remove "dev_pm_domain_attach" in > "acpi_apd_platform_notify". right? In that case, I think so, yes.