From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933960AbbBCOEV (ORCPT ); Tue, 3 Feb 2015 09:04:21 -0500 Received: from mail-pa0-f44.google.com ([209.85.220.44]:61778 "EHLO mail-pa0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753277AbbBCOER (ORCPT ); Tue, 3 Feb 2015 09:04:17 -0500 Date: Tue, 3 Feb 2015 19:34:01 +0530 From: Sudip Mukherjee To: Max Perepelitsyn Cc: teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: sm7xxfb: make smtc_scr_info static Message-ID: <20150203140401.GA12697@sudip-PC> References: <1422953068-12072-1-git-send-email-mperepelitsyn@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1422953068-12072-1-git-send-email-mperepelitsyn@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 03, 2015 at 02:44:28PM +0600, Max Perepelitsyn wrote: > This symbol is never used anywhere else besides sm7xxfb.c Hi Greg, do i need to do anything about this patch? maybe a tested-by or reviewed-by? regards sudip > > Signed-off-by: Max Perepelitsyn > --- > drivers/staging/sm7xxfb/sm7xxfb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/sm7xxfb/sm7xxfb.c b/drivers/staging/sm7xxfb/sm7xxfb.c > index 2ae9fd0..72036c2 100644 > --- a/drivers/staging/sm7xxfb/sm7xxfb.c > +++ b/drivers/staging/sm7xxfb/sm7xxfb.c > @@ -111,7 +111,7 @@ static struct vesa_mode vesa_mode_table[] = { > {"0x31B", 1280, 1024, 24}, > }; > > -struct screen_info smtc_scr_info; > +static struct screen_info smtc_scr_info; > > /* process command line options, get vga parameter */ > static int __init sm7xx_vga_setup(char *options) > -- > 2.2.2 >