From: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
To: Minchan Kim <minchan@kernel.org>
Cc: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Ganesh Mahendran <opensource.ganesh@gmail.com>,
sergey.senozhatsky.work@gmail.com,
Andrew Morton <akpm@linux-foundation.org>,
Jerome Marchand <jmarchan@redhat.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] zram: fix umount-reset_store-mount race condition
Date: Wed, 4 Feb 2015 01:20:32 +0900 [thread overview]
Message-ID: <20150203162031.GC1046@swordfish> (raw)
In-Reply-To: <20150203153923.GA2644@blaptop>
hello,
On (02/04/15 00:39), Minchan Kim wrote:
> So, you mean this?
>
> reset_store
>
> down_write(&zram->init_lock);
> zram_reset_device(zram);
> set_capacity(zram->disk, 0);
> up_write(&zram->init_lock);
>
>
> If so, +1.
> Hope you send a squash patch to Andrew.
yes, that's what I meant
+ zram_exit(void):
down_write(&zram->init_lock);
zram_reset_device(zram);
destroy_device(zram);
up_write(&zram->init_lock);
but I did something different and I think, a bit better than this.
sent a patch several minutes ago.
-ss
prev parent reply other threads:[~2015-02-03 16:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-02 14:08 [PATCH] zram: fix umount-reset_store-mount race condition Sergey Senozhatsky
2015-02-03 3:01 ` Minchan Kim
2015-02-03 14:05 ` Ganesh Mahendran
2015-02-03 14:15 ` Sergey Senozhatsky
2015-02-03 14:52 ` Sergey Senozhatsky
2015-02-03 15:06 ` Sergey Senozhatsky
2015-02-03 15:39 ` Minchan Kim
2015-02-03 16:20 ` Sergey Senozhatsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150203162031.GC1046@swordfish \
--to=sergey.senozhatsky@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=jmarchan@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=minchan@kernel.org \
--cc=opensource.ganesh@gmail.com \
--cc=sergey.senozhatsky.work@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox