From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756180AbbBCR3i (ORCPT ); Tue, 3 Feb 2015 12:29:38 -0500 Received: from mail-pa0-f41.google.com ([209.85.220.41]:54783 "EHLO mail-pa0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756088AbbBCR3e (ORCPT ); Tue, 3 Feb 2015 12:29:34 -0500 Date: Tue, 3 Feb 2015 22:59:19 +0530 From: Sudip Mukherjee To: Mohammad Jamal Cc: oleg.drokin@intel.com, andreas.dilger@intel.com, gregkh@linuxfoundation.org, HPDD-discuss@ml01.01.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: lustre: lustre: lmv: fix sparse warnings about static declarations Message-ID: <20150203172818.GA26315@sudip-PC> References: <1422977085-15897-1-git-send-email-md.jamalmohiuddin@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1422977085-15897-1-git-send-email-md.jamalmohiuddin@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 03, 2015 at 08:54:45PM +0530, Mohammad Jamal wrote: > This patch adds a static keyword to lprocfs_lmv_init_vars and > lprocfs_lmv_module_vars to suppress the sparse warnings about > static declaration have you build tested your patch? After your patch: drivers/staging/lustre/lustre/lmv/lproc_lmv.c:218:31: warning: ‘lmv_proc_target_fops’ defined but not used [-Wunused-variable] drivers/staging/lustre/lustre/lmv/lproc_lmv.c:226:13: warning: ‘lprocfs_lmv_init_vars’ defined but not used [-Wunused-function] WARNING: "lprocfs_lmv_init_vars" [drivers/staging/lustre/lustre/lmv/lmv.ko] undefined! WARNING: "lmv_proc_target_fops" [drivers/staging/lustre/lustre/lmv/lmv.ko] undefined! regards sudip > > Signed-off-by: Mohammad Jamal > --- > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/