From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966377AbbBCRlv (ORCPT ); Tue, 3 Feb 2015 12:41:51 -0500 Received: from mail.skyhub.de ([78.46.96.112]:49683 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965828AbbBCRlt (ORCPT ); Tue, 3 Feb 2015 12:41:49 -0500 Date: Tue, 3 Feb 2015 18:41:23 +0100 From: Borislav Petkov To: Junjie Mao Cc: Doug Thompson , Mauro Carvalho Chehab , linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] edac: remove dev_attr_sdram_scrub_rate on failure Message-ID: <20150203174123.GI3463@pd.tnic> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 03, 2015 at 09:54:41AM +0800, Junjie Mao wrote: Commit message here please. > Signed-off-by: Junjie Mao > --- > drivers/edac/edac_mc_sysfs.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/edac/edac_mc_sysfs.c b/drivers/edac/edac_mc_sysfs.c > index 8e48d32efe37..ab2963bdd0d5 100644 > --- a/drivers/edac/edac_mc_sysfs.c > +++ b/drivers/edac/edac_mc_sysfs.c > @@ -1068,6 +1068,8 @@ fail_unregister_dimm: > continue; > device_unregister(&dimm->dev); > } > + if (mci->set_sdram_scrub_rate || mci->get_sdram_scrub_rate) > + device_remove_file(&mci->dev, &dev_attr_sdram_scrub_rate); > fail_unregister_dev: > device_unregister(&mci->dev); > fail_unregister_bus: Do I see it correctly that the destroy path edac_remove_sysfs_mci_device() doesn't call device_remove_file() on that sysfs node either? Please add that code too. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. --