public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Richard Cochran <richardcochran@gmail.com>
To: John Stultz <john.stultz@linaro.org>
Cc: lkml <linux-kernel@vger.kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@kernel.org>,
	Sasha Levin <sasha.levin@oracle.com>,
	stable@vger.kernel.org
Subject: Re: [PATCH] ntp: Fixup adjtimex freq validation on 32bit systems
Date: Tue, 3 Feb 2015 20:45:43 +0100	[thread overview]
Message-ID: <20150203194543.GA21745@localhost.localdomain> (raw)
In-Reply-To: <1422989859-16456-1-git-send-email-john.stultz@linaro.org>

On Tue, Feb 03, 2015 at 10:57:38AM -0800, John Stultz wrote:
> Unfortunately the patch used LONG_MAX/MIN instead of
> LLONG_MAX/MIN, which was fine on 64bit systems, but being
> much smaller on 32bit systems caused false positives
> resulting in most direct frequency adjustments to fail w/
> EINVAL.

...

> One note:
> 0day kbuild bot complains about
> >> kernel/time/ntp.c:637: warning: comparison is always false due to limited range of data type
> >> kernel/time/ntp.c:639: warning: comparison is always false due to limited range of data type
> 
> We could fix this via adding an extra (BITS_PER_LONG == 64)
> case before we check these to avoid it, but that seemed a
> bit too ugly to me. Thoughts?

So the check is 64 bit only?  Might as well mark it like that
explicitly to avoid needless head scratching of 32 bit people.

Thanks,
Richard

  reply	other threads:[~2015-02-03 19:45 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-03 18:57 [PATCH] ntp: Fixup adjtimex freq validation on 32bit systems John Stultz
2015-02-03 19:45 ` Richard Cochran [this message]
2015-02-04  0:38   ` [PATCH v2] " John Stultz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150203194543.GA21745@localhost.localdomain \
    --to=richardcochran@gmail.com \
    --cc=john.stultz@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=sasha.levin@oracle.com \
    --cc=stable@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox