From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161042AbbBCTvw (ORCPT ); Tue, 3 Feb 2015 14:51:52 -0500 Received: from comal.ext.ti.com ([198.47.26.152]:48524 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756125AbbBCTvt (ORCPT ); Tue, 3 Feb 2015 14:51:49 -0500 Date: Tue, 3 Feb 2015 13:51:34 -0600 From: Felipe Balbi To: Felipe Balbi CC: Pali =?iso-8859-1?Q?Roh=E1r?= , Linux USB Mailing List , Pavel Machek , Aaro Koskinen , Sebastian Reichel , Subject: Re: [PATCH 1/3] usb: gadget: function: phonet: balance usb_ep_disable calls Message-ID: <20150203195134.GE6508@saruman.tx.rr.com> Reply-To: References: <1422918921-5472-1-git-send-email-balbi@ti.com> <201502031717.28789@pali> <20150203191859.GA6508@saruman.tx.rr.com> <201502032027.52712@pali> <20150203193525.GC6508@saruman.tx.rr.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="IvGM3kKqwtniy32b" Content-Disposition: inline In-Reply-To: <20150203193525.GC6508@saruman.tx.rr.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --IvGM3kKqwtniy32b Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Feb 03, 2015 at 01:35:25PM -0600, Felipe Balbi wrote: > On Tue, Feb 03, 2015 at 08:27:52PM +0100, Pali Roh=E1r wrote: > > On Tuesday 03 February 2015 20:18:59 Felipe Balbi wrote: > > > On Tue, Feb 03, 2015 at 05:17:28PM +0100, Pali Roh=E1r wrote: > > > > On Tuesday 03 February 2015 16:43:45 Felipe Balbi wrote: > > > > > Hi, > > > > >=20 > > > > > On Tue, Feb 03, 2015 at 04:31:51PM +0100, Pali Roh=E1r wrote: > > > > > > On Tuesday 03 February 2015 00:15:19 Felipe Balbi wrote: > > > > > > > f_phonet's ->set_alt() method will call > > > > > > > usb_ep_disable() potentially on an endpoint which is > > > > > > > already disabled. That's something the > > > > > > > gadget/function driver must guarantee that it's > > > > > > > always balanced. > > > > > > >=20 > > > > > > > In order to balance the calls, just make sure the > > > > > > > endpoint was enabled before by means of checking the > > > > > > > validity of driver_data. > > > > > > >=20 > > > > > > > Reported-by: Pali Roh=E1r > > > > > > > Signed-off-by: Felipe Balbi > > > > > > > --- > > > > > >=20 > > > > > > Your patches cause that kernel does not print any error > > > > > > message to n900 screen anymore and reboot device in 10 > > > > > > seconds. I did not loaded any external modules. > > > > >=20 > > > > > > In qemu I see this crash in early boot: > > > > > alright, so n900's working fine. I'll wait until you debug > > > > > qemu a little more, thank you > > > >=20 > > > > NO! It does not working, see ^^^^. It break n900 totally! > > >=20 > > > settle down a bit more. I don't have the HW you have and > > > things are working fine on boards I _do_ have, there's not > > > much more I can do to help without you doing your homework. > > > Debug a bit more and bring more information as to what's > > > going on, until then you're on your own. > >=20 > > And what more do you need? It crash on my n900 and also in qemu.=20 > > I sent you kernel crash dump from qemu which introduced *your*=20 > > patches. Before applying your patches there was no crash in early=20 > > boot stage. > >=20 > > In current state I review all 3 patches as: > >=20 > > Rejected-by: Pali Roh=E1r > > [It breaks booting Nokia N900 device] >=20 > next step, figure why it's broken. Working just fine here on AM335x > which has the same musb IP. in any case, .config will help. --=20 balbi --IvGM3kKqwtniy32b Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJU0SbGAAoJEIaOsuA1yqREW3cP/3wfHGXYvT2h30E69QhBEwfw TTFSxoODGIE3W1zEeOTHohK07mAQKP0YQz+LZm91KOImdgH3cxwRbv3ME5/qbtWA MrYxQyY4ENoFV0HO9Km1Xz9U8ZVSyjPsIVO+uqK0ad7SojHn8tRukgbz+0OroAFT zHQEESj8RD6rWFGFjg8GT1P/ZjJIX7K27hqabsB6K3lD95s970BOeKBVeU8vfdLy SNEM74e+eTgcFlrEaBuOyMD+H3pNFvYB5fgS2O/TsHwSw6A+0gA4zBJWUVD+XRiy b5uDJYiAtz5nr6NrjsuHJ1LVGlHvtcTPkHw5vPf7+QMoS1vgsrsFAJIiEFchImjb wbYKqgJF+Wyx13UhN+v5kv69ySIwajkK7QdxkNj1BdvP4s85ALFqRIG5dksEDb/l 5Tf9Vg0dQhLdQHOfJw4owiPAxJMN0EyyZFgigC9TtCYH6VkAhg0FyEtP0GmpTpP8 K8AwW78loFtJyFQ9jPz/jkQhf/y+QVzDdrrDG9j15WUqVI8daSs8pEroaRZweltO nXK+RtlhNq2AV9J+Ayj4Mvyqa3m0p3xxGyF6ieb1e8ncvmrGMsrD3CV1gXk8si0d v69xBgXig5pnSKpQ9bvJsboQpjzq/ou7m8p44B6gtzNyT2tRES20d3aRnhAJurhw WqILYv1CgMHBn2FR2mdd =/hCe -----END PGP SIGNATURE----- --IvGM3kKqwtniy32b--