From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966684AbbBCUC3 (ORCPT ); Tue, 3 Feb 2015 15:02:29 -0500 Received: from arroyo.ext.ti.com ([192.94.94.40]:57739 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966418AbbBCUC2 (ORCPT ); Tue, 3 Feb 2015 15:02:28 -0500 Date: Tue, 3 Feb 2015 14:02:11 -0600 From: Felipe Balbi To: Pali =?iso-8859-1?Q?Roh=E1r?= CC: , Linux USB Mailing List , Pavel Machek , Aaro Koskinen , Sebastian Reichel , Subject: Re: [PATCH 1/3] usb: gadget: function: phonet: balance usb_ep_disable calls Message-ID: <20150203200211.GF6508@saruman.tx.rr.com> Reply-To: References: <1422918921-5472-1-git-send-email-balbi@ti.com> <201502032027.52712@pali> <20150203193525.GC6508@saruman.tx.rr.com> <201502032057.11166@pali> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="oXNgvKVxGWJ0RPMJ" Content-Disposition: inline In-Reply-To: <201502032057.11166@pali> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --oXNgvKVxGWJ0RPMJ Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Tue, Feb 03, 2015 at 08:57:11PM +0100, Pali Roh=E1r wrote: > > > > > > > > f_phonet's ->set_alt() method will call > > > > > > > > usb_ep_disable() potentially on an endpoint which > > > > > > > > is already disabled. That's something the > > > > > > > > gadget/function driver must guarantee that it's > > > > > > > > always balanced. > > > > > > > >=20 > > > > > > > > In order to balance the calls, just make sure the > > > > > > > > endpoint was enabled before by means of checking > > > > > > > > the validity of driver_data. > > > > > > > >=20 > > > > > > > > Reported-by: Pali Roh=E1r > > > > > > > > Signed-off-by: Felipe Balbi > > > > > > > > --- > > > > > > >=20 > > > > > > > Your patches cause that kernel does not print any > > > > > > > error message to n900 screen anymore and reboot > > > > > > > device in 10 seconds. I did not loaded any external > > > > > > > modules. > > > > > >=20 > > > > > > > In qemu I see this crash in early boot: > > > > > > alright, so n900's working fine. I'll wait until you > > > > > > debug qemu a little more, thank you > > > > >=20 > > > > > NO! It does not working, see ^^^^. It break n900 > > > > > totally! > > > >=20 > > > > settle down a bit more. I don't have the HW you have and > > > > things are working fine on boards I _do_ have, there's not > > > > much more I can do to help without you doing your > > > > homework. Debug a bit more and bring more information as > > > > to what's going on, until then you're on your own. > > >=20 > > > And what more do you need? It crash on my n900 and also in > > > qemu. I sent you kernel crash dump from qemu which > > > introduced *your* patches. Before applying your patches > > > there was no crash in early boot stage. > > >=20 > > > In current state I review all 3 patches as: > > >=20 > > > Rejected-by: Pali Roh=E1r > > > [It breaks booting Nokia N900 device] > >=20 > > next step, figure why it's broken. Working just fine here on > > AM335x which has the same musb IP. >=20 > Why is broken? That is easy. You send 3 patches which broke it. as I said, working just fine here: http://hastebin.com/zolunekepo --=20 balbi --oXNgvKVxGWJ0RPMJ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJU0SlDAAoJEIaOsuA1yqREu2AP/AyGy4kT+8GxBUwYL1eDDXnU GEbGUwo0/BaVB8mFRuq5gRII88CJ32nQhT9Gt6bstShPpbbEumVwyQHxv/SFoQ7P w4JgCYkTwBJnLhcTMruxxa25fZFXoNF8TUt9AAj/aCVDN+zizGXWfQf5bBKN4m33 N1cuAUl6V+NPJQ7LOrAkU1ZZgI7zCyyYYLRZdTdDCIyRhe5HMFEz9WC+v/dyVc4J UuYNAkSGOTIW6rvuy5Pm4BEJq2ztk/6ASqIGWccnIpGHUPitMiFhNd3+oTSAtBFd HmbXZ4tz28NU0J2I3UHvTAZv/Gucw+zKds1HyDxamRJ5bcf98UXtv6JdZm+WPooL cIMrkt6VFeJbHwL5kldasX/FvQIKrcvTKV1h/nEUAsHSBnGd3Oui71xBKWrPuUo6 lCZ0pChhr/oMsRr3htclHhf/gDDGWjG2rx/5g/Y5I9qvdMLmxSBQrtOdQaDsoO8L TJJmouA7v962YKp8icq1j0YSeQa/UdZu3oSye+1pJrdlQ6PhOf/Ug5K9wFiDwbiJ kUT+gsP7vqoVL/f8RNI5qqGhwFcAgoQIlaigk40D49Clc2Y6VWfC18Tn9WftotpF pZ+PjdqmMTI9r7qIMpsH+bHYxQYtgxe1dNrEU4kH8mbK6naYo5VqwxYWOt/ThgvT N/3fIEPnEurWNS+xbKYC =44da -----END PGP SIGNATURE----- --oXNgvKVxGWJ0RPMJ--