From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Minchan Kim <minchan@kernel.org>
Cc: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Ganesh Mahendran <opensource.ganesh@gmail.com>,
Jerome Marchand <jmarchan@redhat.com>,
Nitin Gupta <ngupta@vflare.org>,
linux-kernel@vger.kernel.org, nefelim4ag@gmail.com,
eternaleye@gmail.com
Subject: Re: [PATCH] zram: rework reset and destroy path
Date: Wed, 4 Feb 2015 09:45:29 +0900 [thread overview]
Message-ID: <20150204004529.GB527@swordfish> (raw)
In-Reply-To: <20150204003510.GA27787@blaptop>
On (02/04/15 09:35), Minchan Kim wrote:
> > > Create_device just shows the number of created device so I think
> > > no worth to emit per-device information in destroy_devices.
> > > Let's just emit clean up done like old in zram_exit but
> > > use pr_info instead of pr_debug.
> >
> > not critical let's keep it as is (it just mirrors the message from init()),
> > and I wouldn't say it's totally useless now. we allocate space for devices,
> > disk, queue, etc. and we destroy it here.
>
> As I said, it is just minor but at least want to fix pr_debug into
> pr_info.
ah, didn't catch your pr_info() <-> pr_debug() note. need more coffee.
the original message was printed by pr_debug().
will send a one-liner.
-ss
prev parent reply other threads:[~2015-02-04 0:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-03 16:15 [PATCH] zram: rework reset and destroy path Sergey Senozhatsky
2015-02-03 23:42 ` Minchan Kim
2015-02-04 0:24 ` Sergey Senozhatsky
2015-02-04 0:35 ` Minchan Kim
2015-02-04 0:45 ` Sergey Senozhatsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150204004529.GB527@swordfish \
--to=sergey.senozhatsky.work@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=eternaleye@gmail.com \
--cc=jmarchan@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=minchan@kernel.org \
--cc=nefelim4ag@gmail.com \
--cc=ngupta@vflare.org \
--cc=opensource.ganesh@gmail.com \
--cc=sergey.senozhatsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox