From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966844AbbBDApc (ORCPT ); Tue, 3 Feb 2015 19:45:32 -0500 Received: from mail-pa0-f41.google.com ([209.85.220.41]:50256 "EHLO mail-pa0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754617AbbBDApa (ORCPT ); Tue, 3 Feb 2015 19:45:30 -0500 Date: Wed, 4 Feb 2015 09:45:29 +0900 From: Sergey Senozhatsky To: Minchan Kim Cc: Sergey Senozhatsky , Sergey Senozhatsky , Andrew Morton , Ganesh Mahendran , Jerome Marchand , Nitin Gupta , linux-kernel@vger.kernel.org, nefelim4ag@gmail.com, eternaleye@gmail.com Subject: Re: [PATCH] zram: rework reset and destroy path Message-ID: <20150204004529.GB527@swordfish> References: <1422980106-28222-1-git-send-email-sergey.senozhatsky@gmail.com> <20150203234201.GA3583@blaptop> <20150204002450.GA527@swordfish> <20150204003510.GA27787@blaptop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150204003510.GA27787@blaptop> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On (02/04/15 09:35), Minchan Kim wrote: > > > Create_device just shows the number of created device so I think > > > no worth to emit per-device information in destroy_devices. > > > Let's just emit clean up done like old in zram_exit but > > > use pr_info instead of pr_debug. > > > > not critical let's keep it as is (it just mirrors the message from init()), > > and I wouldn't say it's totally useless now. we allocate space for devices, > > disk, queue, etc. and we destroy it here. > > As I said, it is just minor but at least want to fix pr_debug into > pr_info. ah, didn't catch your pr_info() <-> pr_debug() note. need more coffee. the original message was printed by pr_debug(). will send a one-liner. -ss