From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161162AbbBDQ1s (ORCPT ); Wed, 4 Feb 2015 11:27:48 -0500 Received: from mail-lb0-f169.google.com ([209.85.217.169]:49122 "EHLO mail-lb0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966167AbbBDQ1n (ORCPT ); Wed, 4 Feb 2015 11:27:43 -0500 Date: Wed, 4 Feb 2015 17:27:45 +0100 From: Johan Hovold To: Peter Hung Cc: johan@kernel.org, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, tom_tsai@fintek.com.tw, peter_hong@fintek.com.tw, Peter Hung Subject: Re: [PATCH v4 7/7] usb: serial: modify ioctl TIOCGSERIAL for F81232 Message-ID: <20150204162745.GG13757@localhost> References: <1422598421-6236-1-git-send-email-hpeter+linux_kernel@gmail.com> <1422598421-6236-7-git-send-email-hpeter+linux_kernel@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1422598421-6236-7-git-send-email-hpeter+linux_kernel@gmail.com> User-Agent: Mutt/1.5.22 (2013-10-16) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 30, 2015 at 02:13:41PM +0800, Peter Hung wrote: > Set correct product type from 16654 to 16550A and > fix the ioctl TIOCGSERIAL return struct values. > > Signed-off-by: Peter Hung > --- > drivers/usb/serial/f81232.c | 13 +++++++++---- > 1 file changed, 9 insertions(+), 4 deletions(-) > > diff --git a/drivers/usb/serial/f81232.c b/drivers/usb/serial/f81232.c > index 0ed7e36..4d3aba8 100644 > --- a/drivers/usb/serial/f81232.c > +++ b/drivers/usb/serial/f81232.c > @@ -518,13 +518,18 @@ static int f81232_ioctl(struct tty_struct *tty, > > switch (cmd) { > case TIOCGSERIAL: First of all, please break this out into a f81232_get_serial_info helper function. > - memset(&ser, 0, sizeof ser); > - ser.type = PORT_16654; > + memset(&ser, 0, sizeof(ser)); > + ser.flags = ASYNC_SKIP_TEST | ASYNC_AUTO_IRQ; > + ser.xmit_fifo_size = port->bulk_out_size; > + ser.close_delay = 5*HZ; > + ser.closing_wait = 30*HZ; Spaces around * > + No newline. > + ser.type = PORT_16550A; > ser.line = port->minor; > ser.port = port->port_number; > - ser.baud_base = 460800; > + ser.baud_base = 115200; > > - if (copy_to_user((void __user *)arg, &ser, sizeof ser)) > + if (copy_to_user((void __user *)arg, &ser, sizeof(ser))) > return -EFAULT; > > return 0; Johan