From: Marek Vasut <marex@denx.de>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: "Jim-Ting Kuo" <jimtingkuo@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
Brian Norris <computersforpeace@gmail.com>,
Huang Shijie <b32955@freescale.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Ben Hutchings <ben@decadent.org.uk>,
Paul Gortmaker <paul.gortmaker@windriver.com>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] m25p80, spi-nor: add SFDP detect method
Date: Wed, 4 Feb 2015 17:37:21 +0100 [thread overview]
Message-ID: <201502041737.21712.marex@denx.de> (raw)
In-Reply-To: <CACna6ryGUQmkxYEa_T-5AVT15xQBwFi2qoy_yd1+LEXX0ZpG+w@mail.gmail.com>
On Wednesday, February 04, 2015 at 05:06:55 PM, Rafał Miłecki wrote:
> On 4 February 2015 at 16:50, Jim-Ting Kuo <jimtingkuo@gmail.com> wrote:
> > The serial flash discoverable parameters (SFDP) is needed to
> > spi nor devices for some specific features. I added some sfdp
> > structure and detect method. And I hope the method will be
> > useful in the future.
> >
> > The code have been tested on lower version Linux and can
> > successfully work with Macronix chips. So I also modified the
> > chip support list of Macronix.
>
> Please resend without broken white spaces, so we can review/apply it.
btw. after a brief skim over the code, I'd suggest to send the new
functionality and new chip IDs in separate patches.
Best regards,
Marek Vasut
prev parent reply other threads:[~2015-02-04 16:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-04 15:50 [PATCH] m25p80, spi-nor: add SFDP detect method Jim-Ting Kuo
2015-02-04 16:06 ` Rafał Miłecki
2015-02-04 16:37 ` Marek Vasut [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201502041737.21712.marex@denx.de \
--to=marex@denx.de \
--cc=b32955@freescale.com \
--cc=ben@decadent.org.uk \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=geert+renesas@glider.be \
--cc=jimtingkuo@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=paul.gortmaker@windriver.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox