From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161172AbbBDQh1 (ORCPT ); Wed, 4 Feb 2015 11:37:27 -0500 Received: from mail-out.m-online.net ([212.18.0.9]:54774 "EHLO mail-out.m-online.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754766AbbBDQh0 convert rfc822-to-8bit (ORCPT ); Wed, 4 Feb 2015 11:37:26 -0500 X-Auth-Info: pQWkY3yJUnuybEnc002E54pufmXCeIUB0Xvm7NRE/+I= From: Marek Vasut To: =?utf-8?q?Rafa=C5=82_Mi=C5=82ecki?= Subject: Re: [PATCH] m25p80, spi-nor: add SFDP detect method Date: Wed, 4 Feb 2015 17:37:21 +0100 User-Agent: KMail/1.13.7 (Linux/3.13-trunk-amd64; KDE/4.13.1; x86_64; ; ) Cc: "Jim-Ting Kuo" , David Woodhouse , Brian Norris , Huang Shijie , Geert Uytterhoeven , Ben Hutchings , Paul Gortmaker , "linux-mtd@lists.infradead.org" , Linux Kernel Mailing List References: In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 8BIT Message-Id: <201502041737.21712.marex@denx.de> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday, February 04, 2015 at 05:06:55 PM, Rafał Miłecki wrote: > On 4 February 2015 at 16:50, Jim-Ting Kuo wrote: > > The serial flash discoverable parameters (SFDP) is needed to > > spi nor devices for some specific features. I added some sfdp > > structure and detect method. And I hope the method will be > > useful in the future. > > > > The code have been tested on lower version Linux and can > > successfully work with Macronix chips. So I also modified the > > chip support list of Macronix. > > Please resend without broken white spaces, so we can review/apply it. btw. after a brief skim over the code, I'd suggest to send the new functionality and new chip IDs in separate patches. Best regards, Marek Vasut