From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755960AbbBEKdF (ORCPT ); Thu, 5 Feb 2015 05:33:05 -0500 Received: from mail-lb0-f182.google.com ([209.85.217.182]:46539 "EHLO mail-lb0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751139AbbBEKdB (ORCPT ); Thu, 5 Feb 2015 05:33:01 -0500 Date: Thu, 5 Feb 2015 11:33:04 +0100 From: Johan Hovold To: =?iso-8859-1?Q?S=F6ren?= Brinkmann Cc: Linus Walleij , Alexandre Courbot , Johan Hovold , linux-api@vger.kernel.org, Linux Kernel Mailing List , "linux-gpio@vger.kernel.org" , "linux-doc@vger.kernel.org" Subject: Re: [PATCH v4] gpio: lib-sysfs: Add 'wakeup' attribute Message-ID: <20150205103304.GH13757@localhost> References: <1421351389-11660-1-git-send-email-soren.brinkmann@xilinx.com> <20150116111108.GG30960@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.22 (2013-10-16) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 04, 2015 at 10:27:15AM -0800, Sören Brinkmann wrote: > On Wed, 2015-02-04 at 10:19AM +0100, Linus Walleij wrote: > > What needs to happen (IMHO) is to make gpio_chips properly obeying > > the device model, and then add the attributes for fiddling around with > > GPIOs to either the *real* device or create a new char device interface. > > Whatever works best. These mock devices are fragile and never > > worked properly especially in the removal path as Johans recent > > fixes has shown. > > Sure, that would be a nice long-term solution. But until then this patch > would probably be welcomed by some people, without making the brokenness > of this interface much worse. We don't knowingly add broken functionality, and especially not when it will become ABI that needs to be maintained forever. And "this might be useful for someone at some point" is certainly not a reason to break that rule. Johan