public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: devel@driverdev.osuosl.org,
	Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>,
	Chaitanya Hazarey <c@24.io>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>,
	linux-kernel@vger.kernel.org, Greg Donald <gdonald@gmail.com>,
	Koray Gulcu <koray.gulcu@ozu.edu.tr>
Subject: Re: [PATCH v2] staging: rtl8192u: r8192U_core: Fix for possible null pointer dereference
Date: Thu, 5 Feb 2015 15:51:24 +0300	[thread overview]
Message-ID: <20150205125124.GG5336@mwanda> (raw)
In-Reply-To: <20150205124322.GA8137@sudip-PC>

On Thu, Feb 05, 2015 at 06:13:22PM +0530, Sudip Mukherjee wrote:
> if (driver_info) {
> 	stats->RxIs40MHzPacket = driver_info->BW;
> 	if (stats->RxDrvInfoSize != 0)
> 		TranslateRxSignalStuff819xUsb(skb, stats, driver_info);
> }

If driver_info is non-NULL then stats->RxDrvInfoSize is not zero and
also the reverse.  So really you only need to test one.

regards,
dan carpenter


  reply	other threads:[~2015-02-05 12:51 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-29 18:59 [PATCH v2] staging: rtl8192u: r8192U_core: Fix for possible null pointer dereference Rickard Strandqvist
2015-02-02 16:51 ` Sudip Mukherjee
2015-02-04 20:05   ` Rickard Strandqvist
2015-02-05 12:27 ` Dan Carpenter
2015-02-05 12:43   ` Sudip Mukherjee
2015-02-05 12:51     ` Dan Carpenter [this message]
2015-02-05 17:39       ` Rickard Strandqvist
2015-02-06 14:32         ` Sudip Mukherjee
2015-02-07 13:04           ` Rickard Strandqvist

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150205125124.GG5336@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=c@24.io \
    --cc=devel@driverdev.osuosl.org \
    --cc=gdonald@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=koray.gulcu@ozu.edu.tr \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peter.p.waskiewicz.jr@intel.com \
    --cc=rickard_strandqvist@spectrumdigital.se \
    --cc=sudipm.mukherjee@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox